Skip to content

Conversation

darbyjohnston
Copy link
Contributor

Fixes #1720

Changes:

  • Add constexpr to more functions in OpenTime
  • Remove redundant inline on constexpr functions
  • Move constexpr before the return type on functions

Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (82068e3) to head (2f9227b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
- Coverage   79.96%   79.95%   -0.02%     
==========================================
  Files         197      197              
  Lines       21867    21879      +12     
  Branches     4338     4342       +4     
==========================================
+ Hits        17487    17494       +7     
- Misses       2249     2252       +3     
- Partials     2131     2133       +2     
Flag Coverage Δ
py-unittests 79.95% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/opentime/rationalTime.h 93.61% <100.00%> (ø)
src/opentime/timeRange.h 98.18% <ø> (ø)
src/opentime/timeTransform.h 83.33% <100.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82068e3...2f9227b. Read the comment docs.

…y make the function constexpr if possible

Signed-off-by: Darby Johnston <[email protected]>
@darbyjohnston
Copy link
Contributor Author

The last build action failed due to a codecov error:

[2024-04-09T16:08:22.025Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3.1.1/dist/codecov' failed with exit code 255

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meshula meshula merged commit 2c5735c into AcademySoftwareFoundation:main Apr 18, 2024
@reinecke reinecke added this to the Public Beta 17 milestone Jun 24, 2024
@darbyjohnston darbyjohnston deleted the constexpr branch April 27, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

constexpr updates for C++17
4 participants