-
Notifications
You must be signed in to change notification settings - Fork 309
Adds support to filepath_from_url
to support non-encoded URLs
#1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
apetrynet
merged 11 commits into
AcademySoftwareFoundation:main
from
douglascomet:add_support_to_filepath-from-url_for_non_encoded_urls
Oct 13, 2023
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fc0900f
Adds support to `filepath_from_url` to support non-encoded URLs
douglascomet 7d2d7bf
Added additional unittest for parsing `.xml` urls
douglascomet d3ffd2c
Added slash direction conforming
douglascomet 0a5492d
Switched unit test to use strings
douglascomet 7a84575
Switched to regex solution instead of being OS based to allow unit te…
douglascomet fcac9d6
Updated docstring to elaborate on the updated functionality of `filep…
douglascomet 3d68d84
Simplified conditional to be solely regex based
douglascomet a0918a8
Switched to using pathlib solution per PR feedback
douglascomet eedf958
Updated unit test per PR feedback
douglascomet 232c758
Removed unused import
douglascomet e594713
Updated imports per PR feedback
douglascomet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.