Skip to content

Conversation

jminor
Copy link
Collaborator

@jminor jminor commented Nov 23, 2022

This PR adds a --downgrade option to otiotool to make it easy to write out an older OTIO schema.

From the usage statement:

  --downgrade FAMILY:VERSION
                        Downgrade OTIO schema. Only relevant when --output is used to output an OTIO file. FAMILY:VERSION specifies which
                        schema family and version to use. If FAMILY: is omitted, the default OTIO_CORE: is used. For example `--downgrade
                        OTIO_CORE:0.14.0` is equivalent to `--downgrade 0.14.0`. See the OpenTimelineIO documentation for
                        OTIO_DEFAULT_TARGET_VERSION_FAMILY_LABEL for details.

Example:

otiotool -i new_file.otio --downgrade 0.14.0 -o old_file.otio

It uses the downgrade mechanism documented here.

@ssteinbach
Copy link
Collaborator

Could we get an option to dump the known families/versions? I think the API is there to query that.

@ssteinbach
Copy link
Collaborator

(apologies for the close/open, misclick)

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #1485 (907480d) into main (3231f3c) will decrease coverage by 0.07%.
The diff coverage is 15.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   80.11%   80.05%   -0.07%     
==========================================
  Files         197      197              
  Lines       21699    21718      +19     
  Branches     4299     4307       +8     
==========================================
+ Hits        17385    17386       +1     
- Misses       2170     2182      +12     
- Partials     2144     2150       +6     
Flag Coverage Δ
py-unittests 80.05% <15.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-opentimelineio/opentimelineio/console/otiotool.py 69.85% <15.00%> (-3.46%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3231f3c...907480d. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@jminor
Copy link
Collaborator Author

jminor commented Feb 10, 2023

@ssteinbach I added --list-versions which prints this:

❯ otiotool  --list-versions
Available versions for --downgrade FAMILY:VERSION
  OTIO_CORE:0.14.0
  OTIO_CORE:0.15.0
  OTIO_CORE:0.16.0.dev1

jminor and others added 5 commits March 12, 2023 03:30
@jminor
Copy link
Collaborator Author

jminor commented Mar 12, 2023

Thanks for the feedback @JeanChristopheMorinPerso. I think I addressed all of your comments.

@jminor jminor merged commit f7b5855 into AcademySoftwareFoundation:main Mar 12, 2023
@jminor jminor deleted the downgrade branch March 12, 2023 19:36
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
Added --downgrade and --list-versions command line arguments to otiotool as a convenient way to convert to older OTIO schema versions.

Signed-off-by: Joshua Minor <[email protected]>
Signed-off-by: Michele Spina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants