Skip to content

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Oct 26, 2022

Python 3.11 was release on Oct. 24, 2022. This PR adds 3.11 to the CI matrix so that we can make sure everything is working as expected even if we don't publish wheels yet.

Note that in order to get 3.11 wheels, I had to update the manylinux docker images to use manylinux2014. manylinux2010 was a CentOS 6 based imaged while 2014 is a CentOS 7 based image. Because 2014 uses glibc 2.17, we are fully compatible with the vfx platform years we support. Also, 2014 uses GCC 10 (10.2.1 to be precised).

Signed-off-by: Jean-Christophe Morin <[email protected]>
@JeanChristopheMorinPerso
Copy link
Member Author

Well, it looks like we'll need to update the manylinux docker image to 2014.

Signed-off-by: Jean-Christophe Morin <[email protected]>
@JeanChristopheMorinPerso
Copy link
Member Author

I just pushed a commit to update to manylinux 2014.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Merging #1465 (4b66538) into main (d59a358) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1465   +/-   ##
=======================================
  Coverage   78.89%   78.89%           
=======================================
  Files         200      200           
  Lines       21724    21724           
  Branches     4403     4403           
=======================================
  Hits        17140    17140           
  Misses       2354     2354           
  Partials     2230     2230           
Flag Coverage Δ
py-unittests 78.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59a358...4b66538. Read the comment docs.

Signed-off-by: Jean-Christophe Morin <[email protected]>
@meshula
Copy link
Collaborator

meshula commented Oct 29, 2022

Looking good. Is this work in progress or ready to review? If WIP, maybe convert to Draft?

@JeanChristopheMorinPerso
Copy link
Member Author

It is ready to review.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meshula meshula merged commit 33cae7d into AcademySoftwareFoundation:main Oct 29, 2022
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the python311 branch October 29, 2022 23:36
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
* Add Python 3.11 to CI matrix
* Update manylinux docker images to 2014

Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Michele Spina <[email protected]>
@reinecke
Copy link
Collaborator

Fixes #1667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants