-
Notifications
You must be signed in to change notification settings - Fork 309
Add Python 3.11 to CI matrix #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.11 to CI matrix #1465
Conversation
Signed-off-by: Jean-Christophe Morin <[email protected]>
66be756
to
f9d82e6
Compare
Well, it looks like we'll need to update the manylinux docker image to 2014. |
Signed-off-by: Jean-Christophe Morin <[email protected]>
41570e7
to
6a202ec
Compare
I just pushed a commit to update to manylinux 2014. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
=======================================
Coverage 78.89% 78.89%
=======================================
Files 200 200
Lines 21724 21724
Branches 4403 4403
=======================================
Hits 17140 17140
Misses 2354 2354
Partials 2230 2230
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Jean-Christophe Morin <[email protected]>
Looking good. Is this work in progress or ready to review? If WIP, maybe convert to Draft? |
It is ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Add Python 3.11 to CI matrix * Update manylinux docker images to 2014 Signed-off-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Michele Spina <[email protected]>
Fixes #1667 |
Python 3.11 was release on Oct. 24, 2022. This PR adds 3.11 to the CI matrix so that we can make sure everything is working as expected even if we don't publish wheels yet.
Note that in order to get 3.11 wheels, I had to update the manylinux docker images to use
manylinux2014
.manylinux2010
was a CentOS 6 based imaged while 2014 is a CentOS 7 based image. Because 2014 uses glibc 2.17, we are fully compatible with the vfx platform years we support. Also, 2014 uses GCC 10 (10.2.1 to be precised).