Skip to content

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Oct 23, 2022

Link the Issue(s) this Pull Request is related to.

Fixes #1286.

Summarize your change.

seetuptools added back editable installs not too long ago and it now supports extensions!

This PR adds support for installing OTIO in editable mode, using pip install -e ..

Note that due to the nature of OTIO, the binaries are not editable. There is not much we can do in regard to that since every time the C++ code changed, we need to re-compile the extension. But at least the Python files are editable.

Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Merging #1460 (ad62152) into main (d59a358) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1460   +/-   ##
=======================================
  Coverage   78.89%   78.89%           
=======================================
  Files         200      200           
  Lines       21724    21724           
  Branches     4403     4403           
=======================================
  Hits        17140    17140           
  Misses       2354     2354           
  Partials     2230     2230           
Flag Coverage Δ
py-unittests 78.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59a358...ad62152. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, overall looks good to me, and seems like it will make the iteration process slightly less difficult to teach.

A general comment ~ you've left some general comments here in the PR of explanation for details that one can't know without special knowledge. All the comments, in my opinion, belong in the source as comments for reference by future maintainers.

Signed-off-by: Jean-Christophe Morin <[email protected]>
Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@reinecke reinecke merged commit bae84e0 into AcademySoftwareFoundation:main Oct 27, 2022
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the editable_install branch October 27, 2022 17:19
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
* Add support for editable installs

Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Michele Spina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install locally with pip install -e .
4 participants