-
Notifications
You must be signed in to change notification settings - Fork 309
Add support for editable installs #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for editable installs #1460
Conversation
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1460 +/- ##
=======================================
Coverage 78.89% 78.89%
=======================================
Files 200 200
Lines 21724 21724
Branches 4403 4403
=======================================
Hits 17140 17140
Misses 2354 2354
Partials 2230 2230
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change, overall looks good to me, and seems like it will make the iteration process slightly less difficult to teach.
A general comment ~ you've left some general comments here in the PR of explanation for details that one can't know without special knowledge. All the comments, in my opinion, belong in the source as comments for reference by future maintainers.
Signed-off-by: Jean-Christophe Morin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
* Add support for editable installs Signed-off-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Michele Spina <[email protected]>
Link the Issue(s) this Pull Request is related to.
Fixes #1286.
Summarize your change.
seetuptools
added back editable installs not too long ago and it now supports extensions!This PR adds support for installing OTIO in editable mode, using
pip install -e .
.Note that due to the nature of OTIO, the binaries are not editable. There is not much we can do in regard to that since every time the C++ code changed, we need to re-compile the extension. But at least the Python files are editable.