Don't override __iter__ methods #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
changed the title
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
use_cpp_iter
branch
from
22a1e0b to
5b2ca97
Compare
ssteinbach
reviewed
Oct 5, 2022
ssteinbach
reviewed
Oct 5, 2022
Signed-off-by: Jean-Christophe Morin <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
==========================================
+ Coverage 78.83% 78.97% +0.13%
==========================================
Files 203 203
Lines 22252 22252
Branches 4521 4521
==========================================
+ Hits 17543 17574 +31
+ Misses 2437 2402 -35
- Partials 2272 2276 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ssteinbach
approved these changes
Oct 11, 2022
MichaelPlug
pushed a commit
to MichaelPlug/OpenTimelineIO
that referenced
this pull request
Aug 5, 2023
* Use C++ iterator for bindings Signed-off-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Michele Spina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
A while ago, I found out that the
__iter__methods defined in our bindings were being overridden in_core_utils.py. This PR fixes that by making sure we don't override methods that already exist.For example,
OpenTimelineIO/src/py-opentimelineio/opentimelineio-bindings/otio_serializableObjects.cpp
Line 445 in 0763bf6
Note that I changed this only in the
_add_mutable_sequence_methodsfunction._add_mutable_mapping_methodsis slightly different in thatAnyDictionaryactually has an__eq__method built-in and it needs to be overridden with__eq__fromcollections.abc.