-
Notifications
You must be signed in to change notification settings - Fork 309
Improve typing of the drop_frame parameter on the RationalTime.to_timecode method #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typing of the drop_frame parameter on the RationalTime.to_timecode method #1443
Conversation
…ecode method Signed-off-by: Jean-Christophe Morin <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
==========================================
- Coverage 86.38% 84.67% -1.71%
==========================================
Files 201 203 +2
Lines 20854 22547 +1693
Branches 2298 4530 +2232
==========================================
+ Hits 18014 19092 +1078
- Misses 2244 2396 +152
- Partials 596 1059 +463
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Jean-Christophe Morin <[email protected]>
f5316b9
to
c4cf424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just wanted to make sure that I understand the new header and how it ties into this change.
Signed-off-by: Jean-Christophe Morin <[email protected]>
…ecode method (AcademySoftwareFoundation#1443) * Improve typing of the drop_frame parameter on the RationalTime.to_timecode method Signed-off-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Michele Spina <[email protected]>
Summarize your change.
A couple of months ago, I noticed that the
drop_frame
parameter of theRationalTime.to_timecode
method was usingpy::object
as its type. This is confusing for the user.With the change, running
help(opentimelineio.opentime.RationalTime.to_timecode)
returns:And it still works as before: