Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 25, 2022

Bumps src/deps/rapidjson from 8261c1d to 27c3a8d.

Commits
  • 27c3a8d docs: fix simple typo, perecent -> percent
  • 232389d delete unused variable
  • 64faab2 gate definition of symmetric equality operators on impl, not lib
  • 719304b fixes for natvis
  • dd3f730 Make schema dtor robust against exceptions
  • 781a4e6 Try to fix MSVC build.
  • 88f8ddd Include conceptual change from PR 2001.
  • 4695953 Avoid exit-time destructors.
  • 0390b1a Avoid exit-time destructors.
  • 2b2c804 encdedstreamtest: fix use-after-free compile error with gcc-12
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [src/deps/rapidjson](https://github.com/Tencent/rapidjson) from `8261c1d` to `27c3a8d`.
- [Release notes](https://github.com/Tencent/rapidjson/releases)
- [Commits](Tencent/rapidjson@8261c1d...27c3a8d)

---
updated-dependencies:
- dependency-name: src/deps/rapidjson
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Jul 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1358 (66e323e) into main (913f540) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1358   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         196      196           
  Lines       19865    19865           
  Branches     2309     2309           
=======================================
  Hits        17138    17138           
  Misses       2161     2161           
  Partials      566      566           
Flag Coverage Δ
py-unittests 86.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913f540...66e323e. Read the comment docs.

@meshula
Copy link
Collaborator

meshula commented Jul 25, 2022

Note to the OTIO community: I'm not thrilled about the block around line 1233, which solves a race with thread local storage. rapidjson is used extremely commonly, so this must be considered a good solution. I feel like TLS is the elephant gun of solving concurrency problems, and something that will often needs weeding out later when it causes new concurrency problems.

I suspect it doesn't matter in this case, because GenericValue can only be value equatable, not reference equatable.

Would appreciate any other thoughts.

@meshula
Copy link
Collaborator

meshula commented Jul 25, 2022

After discussion on the ASWF Slack, consensus is that the block around 1233 doesn't interact with our code at all.

@meshula meshula merged commit 813947c into main Jul 25, 2022
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Aug 29, 2022
@ssteinbach ssteinbach deleted the dependabot/submodules/src/deps/rapidjson-27c3a8d branch September 30, 2022 05:14
MichaelPlug pushed a commit to MichaelPlug/OpenTimelineIO that referenced this pull request Aug 5, 2023
…oundation#1358)

Review notes after discussion on Slack: The introduction of thread local data around line 1233, and the preceding assert(false) is suspect, but that bit of code doesn't impact OTIO's usage of rapidjson.

Bumps [src/deps/rapidjson](https://github.com/Tencent/rapidjson) from `8261c1d` to `27c3a8d`.
- [Release notes](https://github.com/Tencent/rapidjson/releases)
- [Commits](Tencent/rapidjson@8261c1d...27c3a8d)

---
updated-dependencies:
- dependency-name: src/deps/rapidjson
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Michele Spina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants