Change angle include Imath to quote include, remove multiMediaReference prototype #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rogernelson @jminor After the removal of multiMediaReference.*, the only outstanding issue for the Swift Package Manager is this. |
meshula
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1276 +/- ##
=======================================
Coverage 86.19% 86.19%
=======================================
Files 196 196
Lines 19795 19795
Branches 2310 2310
=======================================
Hits 17062 17062
Misses 2171 2171
Partials 562 562
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
meshula
added a commit
to meshula/OpenTimelineIO
that referenced
this pull request
Apr 19, 2022
…ce prototype (AcademySoftwareFoundation#1276) * Change quote includes to angle includes * Remove prototype multiMediaReference Co-authored-by: Nick Porcino <[email protected]>
jminor
pushed a commit
that referenced
this pull request
May 2, 2022
…ce prototype (#1276) * Change quote includes to angle includes * Remove prototype multiMediaReference Co-authored-by: Nick Porcino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Part of the fix for #1272
Summarize your change.
The Swift Package Manager does not allow setting include paths that require angle brackets. The rest of the OTIO code already uses quote includes, changing the Imath include works for both interned Imath and for system Imath, and resolves the inability of the Swift Package Manager to build OTIO.