Skip to content

Conversation

jchen9
Copy link
Contributor

@jchen9 jchen9 commented Apr 2, 2022

This PR fixes a problem that is only encountered when a marker is found in a media AAF (e.g. one with audio or video data, and only a single clip as the composition.)

@jchen9 jchen9 force-pushed the fix_marker_time branch from c4f2504 to 3f303bc Compare April 2, 2022 02:18
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #1259 (b48cc68) into main (ebd15cd) will increase coverage by 0.06%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
+ Coverage   86.10%   86.17%   +0.06%     
==========================================
  Files         196      196              
  Lines       19671    19697      +26     
  Branches     2308     2309       +1     
==========================================
+ Hits        16937    16973      +36     
+ Misses       2173     2162      -11     
- Partials      561      562       +1     
Flag Coverage Δ
py-unittests 86.17% <93.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...elineio_contrib/adapters/tests/test_aaf_adapter.py 97.86% <90.47%> (-0.23%) ⬇️
...neio_contrib/adapters/advanced_authoring_format.py 81.06% <100.00%> (+0.86%) ⬆️
src/opentimelineio/errorStatus.cpp 44.44% <0.00%> (+3.70%) ⬆️
...pentimelineio-bindings/otio_errorStatusHandler.cpp 70.37% <0.00%> (+5.55%) ⬆️
src/opentimelineio/clip.cpp 80.55% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd15cd...b48cc68. Read the comment docs.

@jchen9 jchen9 changed the title WIP: Add a test case and fix for transcribing markers over a single audio AAF file Add a test case and fix for transcribing markers over a single audio AAF file Apr 2, 2022
Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jchen9 jchen9 requested a review from jminor April 5, 2022 04:04
@jchen9 jchen9 force-pushed the fix_marker_time branch from 0363bbd to c042618 Compare April 5, 2022 21:00
@jminor jminor merged commit 1d3080e into AcademySoftwareFoundation:main Apr 7, 2022
jminor pushed a commit that referenced this pull request May 2, 2022
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants