SVG adapter fixes #1195
Merged
SVG adapter fixes #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix drawing transitions at end of track
Codecov Report
@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
- Coverage 86.08% 86.07% -0.01%
==========================================
Files 191 191
Lines 19228 19227 -1
Branches 2292 2293 +1
==========================================
- Hits 16552 16550 -2
Misses 2123 2123
- Partials 553 554 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
meshula
approved these changes
Jan 16, 2022
jminor
pushed a commit
that referenced
this pull request
Feb 11, 2022
- Check if media reference contains target_url - Fix drawing transitions at end of track
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the delay. I haven't been keeping well for a while.
#1177
Summarize your change.
The SVG Adapter erroneously assumed media_reference always has target_url. Eg. GeneratorReference does not have target_url. I've added a check for the attribute before drawing it.
The adapter failed with timelines with transitions at the end of a track. Added a fix for that.