Skip to content

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Jan 15, 2022

Summarize your change.

I noticed while working on the docs for the Python bindings that the code base had a reference to a deprecated Pybind11 method, get_type. As stated in https://pybind11.readthedocs.io/en/stable/upgrade.html#v2-6, the replacement is py::type::of.

Quote from the doc:

The undocumented h.get_type() method has been deprecated and replaced by py::type::of(h).

This PR replaces the get_type call with py::type::of.

@codecov-commenter
Copy link

Codecov Report

Merging #1194 (86b21d9) into main (1e44ca2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   86.08%   86.08%           
=======================================
  Files         191      191           
  Lines       19228    19228           
  Branches     2292     2292           
=======================================
  Hits        16552    16552           
  Misses       2123     2123           
  Partials      553      553           
Flag Coverage Δ
unittests 86.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lineio/opentime-bindings/opentime_rationalTime.cpp 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e44ca2...86b21d9. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@meshula meshula merged commit 7f3b381 into AcademySoftwareFoundation:main Jan 16, 2022
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the replace_pybind11_deprecated_util_usage branch January 16, 2022 16:24
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants