Update sdist to include submodules #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am tempted to add a test for installing from the sdist... Should I add one? |
reinecke
approved these changes
Nov 19, 2021
reinecke
changed the title
reinecke
pushed a commit
to reinecke/OpenTimelineIO
that referenced
this pull request
Nov 24, 2021
meshula
pushed a commit
that referenced
this pull request
Nov 24, 2021
* Recursively get submodules before generating the sdist (#1152) * Run python package action on release branches as well as main. Co-authored-by: Jean-Christophe Morin <[email protected]>
jminor
pushed a commit
that referenced
this pull request
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the sdist that is uploaded to PyPI.
The problem was reported in https://app.slack.com/client/TKA297NS0/CMQ9J4BQC.
The issue was simply that I forgot to tell GHA to recursively clone and checkout the submodules.
I tested locally by downloading the GHA artifact from my fork and installed the sdist.