-
Notifications
You must be signed in to change notification settings - Fork 310
PyPI publish on release #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPI publish on release #1110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
+ Coverage 82.78% 86.32% +3.54%
==========================================
Files 75 191 +116
Lines 3306 19004 +15698
Branches 0 2105 +2105
==========================================
+ Hits 2737 16406 +13669
- Misses 569 2052 +1483
- Partials 0 546 +546
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
79bb141
to
2b4b261
Compare
I propose we get an hour on the calendar, go through the workflow once with the TSC, and commit this, ASAP. I am very excited for this version. |
Great job. This one installs fine in Blender 2.93 on Windows: |
Makes sense. I'll let the TSC coordinate? Also thanks @tin2tin for the time you took to test:) |
Fixes #988 .
Take two of publishing to PyPI. This builds on #1099 .
This PR introduces a completely new workflow called
publish
(original isn't it?). This new workflow is triggered by a release. Thepython-package
also has a separate job to build thesdist
.Compared to #1099 , the publishing is no more triggered by pushing tags.
The release process would look like this:
maintainers/download_gha_artifact.py
to download the wheels locally and manually upload them in https://test.pypi.org if we want.publish
workflow will kick in. It will download the artifacts from the tag associated to the release and upload them to https://pypi.org..dev...
at the end.I tested all this in my OpenTimelineIO fork. You can see the commit that I used for the tag (v0.14.0.dev5) here and the actual release here. The release can be seen here
This PR also introduces a script to download wheels from a build. Handy if you want to upload wheels in https://test.pypi.org for example. The script by default only requires to pass the commit hash (the full length one) and a GitHub Personal Access Token.
Additional parameters can be used to set the workflow name from which to download the artifact., the artifact name and the directory where the artifact will be extracted to.
The output looks like:
I hope this covers what we discussed in the last TSC meeting. If not let me know and I'll adjust.