Use equalWithAbsError instead of equal operator for float #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
make test
fails ontestBinaryVecMethods
due to float error.Version
3.1.3
Environments
Detail
These
assert
with==
fails on comparingf[i].y
andf1[i].cross(?)
.Imath/src/python/PyImathTest/pyImathTest.in
Line 589 in 6402a53
Imath/src/python/PyImathTest/pyImathTest.in
Line 604 in 6402a53
Verified with
print
This float errors only happen on these 2 asserts with
cross
.make test
passes without failures with this PR.