Skip to content

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Oct 13, 2021

Problem

make test fails on testBinaryVecMethods due to float error.

Version

3.1.3

Environments

  • OS: CentOS7
  • Toolchain: GCC 11.2
  • CPU: Broadwell

Detail

These assert with == fails on comparing f[i].y and f1[i].cross(?).

assert(f[i] == f1[i].cross(f2[i]))

assert(f[i] == f1[i].cross(v))

Verified with print

print(f[i].y)
print(f1[i].cross(f2[i]).y)

7.900001525878906
7.900001049041748

This float errors only happen on these 2 asserts with cross. make test passes without failures with this PR.

100% tests passed, 0 tests failed out of 38
Total Test time (real) = 5.63 sec

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but needs a CLA to be completed to merge.

@splhack
Copy link
Contributor Author

splhack commented Oct 19, 2021

thanks, our team is working on the Corporate CLA process.

@splhack splhack force-pushed the fix-testBinaryVecMethods branch from 364b833 to 5750627 Compare November 2, 2021 19:59
@splhack
Copy link
Contributor Author

splhack commented Nov 2, 2021

@meshula sorry it took long time, signed Corp CLA and signed-off for DCO.

@meshula
Copy link
Contributor

meshula commented Nov 2, 2021

thanks!

@meshula meshula merged commit ff2f742 into AcademySoftwareFoundation:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants