Skip to content

Use React.PureComponent instead shallowCompare #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use React.PureComponent instead shallowCompare #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ItemCell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,12 @@ import {
TouchableHighlight,
} from 'react-native'
import Icon from 'react-native-vector-icons/FontAwesome'
import shallowCompare from 'react-addons-shallow-compare'

const IC_GREY_BORDER_COLOR = '#C8C7CC'

class ItemCell extends React.Component {
class ItemCell extends React.PureComponent {
state: Object

shouldComponentUpdate(nextProps: Object, nextState: Object) {
return shallowCompare(this, nextProps, nextState)
}

_renderDisclosureIndicator () {
const { showDisclosureIndicator, value } = this.props
if (showDisclosureIndicator && !value) {
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
"ios"
],
"dependencies": {
"react-native-vector-icons": ">=1.0.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native-vector-icons should still be a dependency. Please do not remove it :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native-vector-icons is not touched and all the time is in dependency, only last character was removed from this line.
Please check again my PR and correct me if I'm wrong.

"react-addons-shallow-compare": "^15.3.1"
"react-native-vector-icons": ">=1.0.4"
},
"author": "Alvaro Medina Ballester",
"license": "MIT",
Expand Down