-
Notifications
You must be signed in to change notification settings - Fork 3.7k
添加微雪电子esp32-s3-touch-lcd-3.49系列的支持 #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
包含与项目其他文件风格不一致的代码
current_theme = DARK_THEME; | ||
} else if (current_theme_name_ == "light") { | ||
current_theme = LIGHT_THEME; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里代码可否移除?
}; | ||
|
||
// Current theme - initialize based on default config | ||
static ThemeColors current_theme = LIGHT_THEME; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里代码已经不兼容新版本
|
||
lv_draw_sw_rgb565_swap(color_map, lv_area_get_width(area) * lv_area_get_height(area)); | ||
|
||
#if (EXAMPLE_Rotate_90 == 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个宏会产生作用吗?如果会的话,这个命名是不是不太合适,像是其他例子代码复制过来的。
if(rotation != LV_DISPLAY_ROTATION_0) | ||
{ | ||
lv_color_format_t cf = lv_display_get_color_format(drv); | ||
/*Calculate the position of the rotated area*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
缩进请使用4空格
int offsetx2 = EXAMPLE_LCD_H_RES; | ||
int offsety2 = offgap; | ||
#if (EXAMPLE_Rotate_90 == 1) | ||
uint16_t *map = (uint16_t *)dest_map; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(uint16_t ) 改为 (uint16_t)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(uint16_t ) 改为 (uint16_t)
这个是什么意思?(uint16_t )修改成(uint16_t)是这个意思吗
const int dmalen = (LVGL_DMA_BUFF_LEN / 2); | ||
int offsetx1 = 0; | ||
int offsety1 = 0; | ||
int offsetx2 = EXAMPLE_LCD_H_RES; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
宏的命名可否跟其他板子统一
} | ||
|
||
static void TouchInputReadCallback(lv_indev_t * indev, lv_indev_data_t *indevData) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该是 static void TouchInputReadCallback(lv_indev_t * indev, lv_indev_data_t *indevData) {
ESP_ERROR_CHECK(i2c_new_master_bus(&i2c_bus_cfg, &touch_i2c_bus_)); | ||
|
||
i2c_device_config_t dev_cfg = | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该是 i2c_device_config_t dev_cfg = {
ESP_LOGE("Touch","(%ld,%ld)",indevData->point.x,indevData->point.y); | ||
} | ||
else | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该是 } else {
No description provided.