Checkout/transak primary sale #317
Conversation
Missing query contract functions, building contractcall function data, compressor and encoder
Plugins/SequencePlugin/Source/SequencePlugin/Private/Checkout/Transak/TransakCheckout.cpp
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Private/Checkout/Transak/TransakCheckout.cpp
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Private/Checkout/Transak/TransakCheckout.cpp
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Private/Checkout/Transak/TransakCheckout.cpp
Show resolved
Hide resolved
| } | ||
|
|
||
|
|
||
| FString UTransakCheckout::BuildNFTCheckoutLinkFromERC1155(UERC1155SaleContract* SaleContract, const FTransakNFTData TransakNFTData, const FTransakContractId& ContractId, const TArray<uint8>& Data, const TArray<FString>& Proof) |
There was a problem hiding this comment.
Is there a way to make the Proof and Data parameters optional?
There was a problem hiding this comment.
not if its to be blueprint compatible
There was a problem hiding this comment.
Gotcha. Could we maybe add a tooltip to the BP and add some C++ overload functions?
There was a problem hiding this comment.
Also, is there a blueprint for this already?
Plugins/SequencePlugin/Source/SequencePlugin/Private/Checkout/Transak/TransakNFTDataEncoder.cpp
Outdated
Show resolved
Hide resolved
...ins/SequencePlugin/Source/SequencePlugin/Public/Checkout/Transak/Structs/TransakContractId.h
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Public/Checkout/Transak/Structs/TransakNFTData.h
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Public/Types/ERC1155SaleContract.h
Outdated
Show resolved
Hide resolved
Plugins/SequencePlugin/Source/SequencePlugin/Private/Checkout/Transak/TransakCheckout.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| for (const FString& TokenIDString : TransakNFTData.TokenID) | ||
| { | ||
| int32 ParsedTokenId = FCString::Atoi(*TokenIDString); |
There was a problem hiding this comment.
Just a random thought - what do you think about making a wrapper function for converting strings to ints with a more readable name in a future PR? I know that this is a built-in function that should be rather well-known to C/C++ devs, but maybe would be worthwhile anyways as we wouldn't have to do as much mental gymnastics? Or is that just unnecessary overhead? I'm not really sure... What do you think?
| #include "TransakNftData.generated.h" | ||
|
|
||
| UENUM(BlueprintType) | ||
| enum class ENFTType : uint8 |
There was a problem hiding this comment.
Nitpick: maybe rename to ENftType to make it easier to read? When I first read it I thought the E was part of the word (curse you Unreal and your one-letter prefixes on class names!)
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: