Skip to content

Conversation

inha-kim
Copy link

@inha-kim inha-kim commented Apr 10, 2025

Docs Checklist

Please ensure you have addressed documentation updates if needed as part of this PR:

  • I have created a separate PR on the sequence docs repository for documentation updates: Link to docs PR
  • No documentation update is needed for this change.

Remaining work:

  • I was unable to test the endpoints with eth client calls since there was an ABI decoding issue. Andy was looking into this, so once that is wrapped up the endpoints can be tested with those properly. For now, the helper functions have the eth client calls commented out and will return a hardcoded mock data value
  • The mock data values for ERC721 contract calls are faulty and so the functionality remains untested
  • Mock data for Sarine marketplace api calls remain untested

I don't have any days remaining and am blocked by work from Sequence side so I'll leave the ticket here, but the remaining work should ideally be as simple as uncommenting implemented features, once blockers are resolved.

#307 should be merged before this

ZemindJan and others added 30 commits February 7, 2025 14:43
… Marketplace and Wallet reference in Checkout Subsystem
… back as JSON then converting it into local objects
…n ids each time are unique. In addition, exposed the session id in the SequenceAPI
Set up and start validation. Calculate digest and compare (failing currently )
Construction of signature base and verifying signature process using unreals OPENSSL library. Included Open SSL PublicDependencyModule
Implemented Signature tampering checks for all http requesthandler calls.
@inha-kim inha-kim requested a review from a team April 10, 2025 18:44
@inha-kim inha-kim requested a review from a team as a code owner April 10, 2025 18:44
@BellringerQuinn BellringerQuinn changed the base branch from master to v2 April 15, 2025 13:14
Base automatically changed from v2 to master May 8, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants