fix: Swap to liblzma from lzma-rs introduced issue (#407)

* AI Generated

* Delete LZMA_FIX_SUMMARY.md

Signed-off-by: Chris Hennick <[email protected]>

* Move new test into tests directory

* style: cargo fmt --all

---------

Signed-off-by: Chris Hennick <[email protected]>
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
Co-authored-by: Chris Hennick <[email protected]>
Co-authored-by: hennickc <[email protected]>

Author: amazon-q-developer[bot]

src/compression.rs

@@ -309,7 +309,10 @@ impl<R: io::BufRead> Decompressor<R> {
             #[cfg(feature = "lzma")]
             CompressionMethod::Lzma => Decompressor::Lzma(liblzma::bufread::XzDecoder::new_stream(
                 reader,
-                liblzma::stream::Stream::new_lzma_decoder(0).unwrap(),
+                // Use u64::MAX for unlimited memory usage, matching the previous behavior
+                // from lzma-rs. Using 0 would set the smallest memory limit, which is
+                // problematic in ancient liblzma versions (5.2.3 and earlier).
+                liblzma::stream::Stream::new_lzma_decoder(u64::MAX).unwrap(),
             )),
             #[cfg(feature = "xz")]
             CompressionMethod::Xz => Decompressor::Xz(liblzma::bufread::XzDecoder::new(reader)),

tests/bug398.rs

@@ -0,0 +1,28 @@
+#!/usr/bin/env rust-script
+
+//! Simple test to verify the LZMA memory limit fix
+//! This script tests that LZMA decompression works with the new unlimited memory setting
+
+#[cfg(feature = "lzma")]
+fn main() -> Result<(), Box<dyn std::error::Error>> {
+    println!("Testing LZMA memory limit fix...");
+
+    // Test that we can create an LZMA decoder with u64::MAX memory limit
+    // This would fail in ancient liblzma versions if we used 0
+    let _stream = liblzma::stream::Stream::new_lzma_decoder(u64::MAX)?;
+    println!("✓ Successfully created LZMA decoder with unlimited memory (u64::MAX)");
+
+    // Test that the old problematic value would work too (for comparison)
+    // Note: This might fail in ancient versions, but should work in modern ones
+    let _stream_old = liblzma::stream::Stream::new_lzma_decoder(0);
+    match _stream_old {
+        Ok(_) => println!("✓ Old parameter (0) also works in this liblzma version"),
+        Err(e) => println!(
+            "⚠ Old parameter (0) fails as expected in ancient versions: {}",
+            e
+        ),
+    }
+
+    println!("Test completed successfully!");
+    Ok(())
+}