[#28529] DocDB: Disable object locking in few tests where DMLs are expected to fail when run in parallel with DDLs

Summary:
`PgCacheRefreshTest` tests were failing because the object locking preview flag was being modified with adding the flag to `allowed_preview_flags_csv`. Same with `PgAddColumnDefaultConcurrencyTest`.

Java tests `TestAlterTableWithConcurrentTxn` and `TestPgCacheConsistency` expect DMLs to fail when run in concurrent/before/after DDLs with errors like catalog version mismatch etc. This isn't true with object locking, hence disabled the feature for these tests.
Jira: DB-18224

Test Plan:
Jenkins

Enabled object locking by default, and ran
./yb_build.sh --cxx-test pgwrapper_pg_alter_add_column_default-test --gtest_filter *PgAddColumnDefaultConcurrencyTest.AddColumnDefaultConcurrency*
./yb_build.sh --cxx-test pgwrapper_pg_cache_refresh-test --gtest_filter PgCacheRefreshTest*
./yb_build.sh --java-test 'org.yb.pgsql.TestAlterTableWithConcurrentTxn'
./yb_build.sh --java-test 'org.yb.pgsql.TestPgCacheConsistency'

Reviewers: rthallam, amitanand

Reviewed By: rthallam

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D46550

Author: basavaraj29

java/yb-pgsql/src/test/java/org/yb/pgsql/TestAlterTableWithConcurrentTxn.java

@@ -35,6 +35,16 @@ protected Map<String, String> getMasterFlags() {
     return flagMap;
   }
 
+  @Override
+  protected Map<String, String> getTServerFlags() {
+    // The test suite asserts for DML failing when run in concurrent to ALTER,
+    // and doesn't expect proper wait-on behavior for DML-DDL interaction.
+    Map<String, String> flagMap = super.getTServerFlags();
+    flagMap.put("allowed_preview_flags_csv", "enable_object_locking_for_table_locks");
+    flagMap.put("enable_object_locking_for_table_locks", "false");
+    return flagMap;
+  }
+
   private static final Logger LOG = LoggerFactory.getLogger(TestAlterTableWithConcurrentTxn.class);
 
   // When a transaction is performed on a table that is altered,

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgCacheConsistency.java

@@ -47,6 +47,10 @@ public class TestPgCacheConsistency extends BasePgSQLTest {
   protected Map<String, String> getTServerFlags() {
     Map<String, String> flags = super.getTServerFlags();
     appendToYsqlPgConf(flags, "log_statement=all");
+    // The test suite asserts for DML failing with catalog version mismatch when run
+    // immediately after DDLs, which isn't true with object locking enabled.
+    flags.put("allowed_preview_flags_csv", "enable_object_locking_for_table_locks");
+    flags.put("enable_object_locking_for_table_locks", "false");
     return flags;
   }
 

src/yb/yql/pgwrapper/pg_alter_add_column_default-test.cc

@@ -153,6 +153,10 @@ class PgAddColumnDefaultConcurrencyTest : public PgAddColumnDefaultTest {
     PgAddColumnDefaultTest::UpdateMiniClusterOptions(opts);
     // This test verifies behavior without table-level locking and transactional DDL.
     // Both features are disabled to concurrent inserts during ALTER TABLE.
+    AppendCsvFlagValue(opts->extra_tserver_flags, "allowed_preview_flags_csv",
+                       "ysql_yb_ddl_transaction_block_enabled");
+    AppendCsvFlagValue(opts->extra_tserver_flags, "allowed_preview_flags_csv",
+                       "enable_object_locking_for_table_locks");
     opts->extra_tserver_flags.emplace_back("--enable_object_locking_for_table_locks=false");
     opts->extra_tserver_flags.emplace_back("--ysql_yb_ddl_transaction_block_enabled=false");
   }

src/yb/yql/pgwrapper/pg_cache_refresh-test.cc

@@ -32,6 +32,8 @@ class PgCacheRefreshTest : public LibPqTestBase {
     LibPqTestBase::UpdateMiniClusterOptions(opts);
     // Tests here run DDLs concurrently with DMLs. Such behavior will not be possible
     // with table locks enabled.
+    opts->extra_tserver_flags.emplace_back(
+        "--allowed_preview_flags_csv=enable_object_locking_for_table_locks");
     opts->extra_tserver_flags.emplace_back("--enable_object_locking_for_table_locks=false");
   }