starboard: Uniquely name GetConfigurationApi methods (#7142)

go/cobalt-flatten-starboard-namespace

This change renames platform-specific functions to include a unique
platform suffix (e.g., GetConfigurationApi becomes
GetConfigurationApiAndroid).

With unique function names established, platform-specific namespaces
like starboard::android::shared, starboard::linux::shared,
starboard::raspi::skia, etc., are removed. All configuration logic now
resides directly within the top-level starboard namespace, simplifying
the codebase and improving code discoverability

Bug: 441955897

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: kjyoun

starboard/android/shared/configuration.cc

@@ -17,36 +17,35 @@
 #include "starboard/common/configuration_defaults.h"
 #include "starboard/extension/configuration.h"
 
-namespace starboard::android::shared {
-
+namespace starboard {
 namespace {
 
-const char* CobaltUserOnExitStrategy() {
+const char* CobaltUserOnExitStrategyAndroid() {
   // On Android, we almost never want to actually terminate the process, so
   // instead indicate that we would instead like to be suspended when users
   // initiate an "exit".
   return "suspend";
 }
 
-int CobaltEglSwapInterval() {
+int CobaltEglSwapIntervalAndroid() {
   // Switch Android's SurfaceFlinger queue to "async mode" so that we don't
   // queue up rendered frames which would interfere with frame timing and
   // more importantly lead to input latency.
   return 0;
 }
 
-bool CobaltEnableQuic() {
-  return 0;
+bool CobaltEnableQuicAndroid() {
+  return false;
 }
 
 const CobaltExtensionConfigurationApi kConfigurationApi = {
     kCobaltExtensionConfigurationName,
     3,
-    &CobaltUserOnExitStrategy,
+    &CobaltUserOnExitStrategyAndroid,
     &CobaltRenderDirtyRegionOnlyDefault,
-    &CobaltEglSwapInterval,
+    &CobaltEglSwapIntervalAndroid,
     &CobaltFallbackSplashScreenUrlDefault,
-    &CobaltEnableQuic,
+    &CobaltEnableQuicAndroid,
     &CobaltSkiaCacheSizeInBytesDefault,
     &CobaltOffscreenTargetCacheSizeInBytesDefault,
     &CobaltEncodedImageCacheSizeInBytesDefault,
@@ -70,8 +69,8 @@ const CobaltExtensionConfigurationApi kConfigurationApi = {
 
 }  // namespace
 
-const void* GetConfigurationApi() {
+const void* GetConfigurationApiAndroid() {
   return &kConfigurationApi;
 }
 
-}  // namespace starboard::android::shared
+}  // namespace starboard

starboard/android/shared/configuration.h

@@ -15,10 +15,10 @@
 #ifndef STARBOARD_ANDROID_SHARED_CONFIGURATION_H_
 #define STARBOARD_ANDROID_SHARED_CONFIGURATION_H_
 
-namespace starboard::android::shared {
+namespace starboard {
 
-const void* GetConfigurationApi();
+const void* GetConfigurationApiAndroid();
 
-}  // namespace starboard::android::shared
+}  // namespace starboard
 
 #endif  // STARBOARD_ANDROID_SHARED_CONFIGURATION_H_

starboard/android/shared/system_get_extensions.cc

@@ -40,7 +40,7 @@ const void* SbSystemGetExtension(const char* name) {
     return starboard::android::shared::GetPlatformServiceApi();
   }
   if (strcmp(name, kCobaltExtensionConfigurationName) == 0) {
-    return starboard::android::shared::GetConfigurationApi();
+    return starboard::GetConfigurationApiAndroid();
   }
   if (strcmp(name, kCobaltExtensionMediaSessionName) == 0) {
     // TODO(b/377019873): Re-enable

starboard/common/configuration_defaults.h

@@ -93,7 +93,6 @@ using starboard::CobaltSkiaGlyphAtlasHeightDefault;
 using starboard::CobaltSkiaGlyphAtlasWidthDefault;
 using starboard::CobaltSoftwareSurfaceCacheSizeInBytesDefault;
 }  // namespace common
-
 }  // namespace starboard
 
 #endif  // STARBOARD_COMMON_CONFIGURATION_DEFAULTS_H_

starboard/linux/shared/configuration.cc

@@ -19,11 +19,9 @@
 
 // Omit namespace linux due to symbol name conflict.
 namespace starboard {
-namespace shared {
-
 namespace {
 
-int CobaltEglSwapInterval() {
+int CobaltEglSwapIntervalLinux() {
   // This platform uses a compositor to present the rendering output, so
   // set the swap interval to update the buffer immediately. That buffer
   // will then be presented by the compositor on its own time.
@@ -35,7 +33,7 @@ const CobaltExtensionConfigurationApi kConfigurationApi = {
     3,
     &CobaltUserOnExitStrategyDefault,
     &CobaltRenderDirtyRegionOnlyDefault,
-    &CobaltEglSwapInterval,
+    &CobaltEglSwapIntervalLinux,
     &CobaltFallbackSplashScreenUrlDefault,
     &CobaltEnableQuicDefault,
     &CobaltSkiaCacheSizeInBytesDefault,
@@ -61,9 +59,8 @@ const CobaltExtensionConfigurationApi kConfigurationApi = {
 
 }  // namespace
 
-const void* GetConfigurationApi() {
+const void* GetConfigurationApiLinux() {
   return &kConfigurationApi;
 }
 
-}  // namespace shared
 }  // namespace starboard

starboard/linux/shared/configuration.h

@@ -15,13 +15,10 @@
 #ifndef STARBOARD_LINUX_SHARED_CONFIGURATION_H_
 #define STARBOARD_LINUX_SHARED_CONFIGURATION_H_
 
-// Omit namespace linux due to symbol name conflict.
 namespace starboard {
-namespace shared {
 
-const void* GetConfigurationApi();
+const void* GetConfigurationApiLinux();
 
-}  // namespace shared
 }  // namespace starboard
 
 #endif  // STARBOARD_LINUX_SHARED_CONFIGURATION_H_

starboard/linux/shared/system_get_extensions.cc

@@ -55,7 +55,7 @@ const void* SbSystemGetExtension(const char* name) {
     return starboard::shared::GetPlatformServiceApi();
   }
   if (strcmp(name, kCobaltExtensionConfigurationName) == 0) {
-    return starboard::shared::GetConfigurationApi();
+    return starboard::GetConfigurationApiLinux();
   }
   if (strcmp(name, kCobaltExtensionCrashHandlerName) == 0) {
     return starboard::GetCrashHandlerApi();

starboard/linux/x64x11/skia/configuration.cc

@@ -17,21 +17,17 @@
 #include "starboard/common/configuration_defaults.h"
 #include "starboard/extension/configuration.h"
 
-// Omit namespace linux due to symbol name conflict.
 namespace starboard {
-namespace x64x11 {
-namespace skia {
-
 namespace {
 
-int CobaltEglSwapInterval() {
+int CobaltEglSwapIntervalLinuxSkia() {
   // This platform uses a compositor to present the rendering output, so
   // set the swap interval to update the buffer immediately. That buffer
   // will then be presented by the compositor on its own time.
   return 0;
 }
 
-const char* CobaltRasterizerType() {
+const char* CobaltRasterizerTypeLinuxSkia() {
   // Use the skia hardware rasterizer.
   return "hardware";
 }
@@ -41,7 +37,7 @@ const CobaltExtensionConfigurationApi kConfigurationApi = {
     3,
     &CobaltUserOnExitStrategyDefault,
     &CobaltRenderDirtyRegionOnlyDefault,
-    &CobaltEglSwapInterval,
+    &CobaltEglSwapIntervalLinuxSkia,
     &CobaltFallbackSplashScreenUrlDefault,
     &CobaltEnableQuicDefault,
     &CobaltSkiaCacheSizeInBytesDefault,
@@ -59,18 +55,16 @@ const CobaltExtensionConfigurationApi kConfigurationApi = {
     &CobaltReduceCpuMemoryByDefault,
     &CobaltReduceGpuMemoryByDefault,
     &CobaltGcZealDefault,
-    &CobaltRasterizerType,
+    &CobaltRasterizerTypeLinuxSkia,
     &CobaltEnableJitDefault,
     &CobaltFallbackSplashScreenTopicsDefault,
     &CobaltCanStoreCompiledJavascriptDefault,
 };
 
 }  // namespace
 
-const void* GetConfigurationApi() {
+const void* GetConfigurationApiLinuxSkia() {
   return &kConfigurationApi;
 }
 
-}  // namespace skia
-}  // namespace x64x11
 }  // namespace starboard

starboard/linux/x64x11/skia/configuration.h

@@ -15,15 +15,10 @@
 #ifndef STARBOARD_LINUX_X64X11_SKIA_CONFIGURATION_H_
 #define STARBOARD_LINUX_X64X11_SKIA_CONFIGURATION_H_
 
-// Omit namespace linux due to symbol name conflict.
 namespace starboard {
-namespace x64x11 {
-namespace skia {
 
-const void* GetConfigurationApi();
+const void* GetConfigurationApiLinuxSkia();
 
-}  // namespace skia
-}  // namespace x64x11
 }  // namespace starboard
 
 #endif  // STARBOARD_LINUX_X64X11_SKIA_CONFIGURATION_H_

starboard/linux/x64x11/skia/system_get_extensions.cc

@@ -20,7 +20,7 @@
 
 const void* SbSystemGetExtension(const char* name) {
   if (strcmp(name, kCobaltExtensionConfigurationName) == 0) {
-    return starboard::x64x11::skia::GetConfigurationApi();
+    return starboard::GetConfigurationApiLinuxSkia();
   }
   return NULL;
 }