Skip to content

Conversation

lukecarbis
Copy link
Contributor

This PR removes all non-stream text domains!

Two things to note:

  1. Where we are referring specifically to something which is occurring in another plugin, I'm using _x with that plugin's slug for context
  2. I have not added any additional context where we are referring to WordPress core, because that's the default context, anyway. For example, _x( 'Posts', 'default', 'stream' ) is not very helpful.

@ThemeBoy @deckerweb - I'd love to get your thoughts on this approach.

@fjarrett please review. It would be great to release this with 2.0.1.

frankiejarrett added a commit that referenced this pull request Oct 1, 2014
@frankiejarrett frankiejarrett merged commit dcfd036 into develop Oct 1, 2014
@frankiejarrett frankiejarrett deleted the stream-underscore-underscore branch October 1, 2014 10:47
@frankiejarrett
Copy link
Contributor

Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants