Add support for migrating comments for tables on MySQL #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveRecord 5 allows to specify the `comment` option on `create_table`, but this option adds the comment for tables not a primary key.
This commit adds support for migrating comments for tables with `--mysql-change-table-comment` option. This migration is skipped if `--ignore-table-comment` option is passed.
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for migrating comments for tables with
--mysql-change-table-commentoption.This migration is skipped if
--ignore-table-commentoption is passed.And this PR fixes an issue about the
commentoption oncreate_table.ActiveRecord 5 allows to specify it, but this option adds the comment for tables not a primary key.