chore!: remove node 18 support (#19972)

patak-dev · sapphi-red · web-flow · commit 00b8a98f3637 · 2025-05-16T10:48:18.000+09:00
Co-authored-by: sapphi-red &lt;49056869+sapphi-red@users.noreply.github.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -63,7 +63,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node_version: [18, 20, 22]
+        node_version: [20, 22]
         include:
           # Active LTS + other OS
           - os: macos-latest
diff --git a/docs/guide/index.md b/docs/guide/index.md
@@ -44,7 +44,7 @@ The supported template presets are:
 ## Scaffolding Your First Vite Project
 
 ::: tip Compatibility Note
-Vite requires [Node.js](https://nodejs.org/en/) version 18+ or 20+. However, some templates require a higher Node.js version to work, please upgrade if your package manager warns about it.
+Vite requires [Node.js](https://nodejs.org/en/) version 20+. However, some templates require a higher Node.js version to work, please upgrade if your package manager warns about it.
 :::
 
 ::: code-group
diff --git a/eslint.config.js b/eslint.config.js
@@ -52,7 +52,7 @@ export default tseslint.config(
     },
     settings: {
       node: {
-        version: '^18.0.0 || ^20.0.0 || >=22.0.0',
+        version: '^20.0.0 || >=22.0.0',
       },
     },
     plugins: {
@@ -66,7 +66,7 @@ export default tseslint.config(
       'n/no-unsupported-features/node-builtins': [
         'error',
         {
-          // TODO: remove this when we don't support Node 18 anymore
+          // TODO: remove this when we don't support Node 20 anymore
           ignores: ['Response', 'Request', 'fetch'],
         },
       ],
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^18.0.0 || ^20.0.0 || >=22.0.0"
+    "node": "^20.0.0 || >=22.0.0"
   },
   "homepage": "https://vite.dev/",
   "repository": {
diff --git a/packages/create-vite/README.md b/packages/create-vite/README.md
@@ -3,7 +3,7 @@
 ## Scaffolding Your First Vite Project
 
 > **Compatibility Note:**
-> Vite requires [Node.js](https://nodejs.org/en/) version 18+, 20+. However, some templates require a higher Node.js version to work, please upgrade if your package manager warns about it.
+> Vite requires [Node.js](https://nodejs.org/en/) version 20+. However, some templates require a higher Node.js version to work, please upgrade if your package manager warns about it.
 
 With NPM:
 
diff --git a/packages/create-vite/build.config.ts b/packages/create-vite/build.config.ts
@@ -11,7 +11,7 @@ export default defineBuildConfig({
   rollup: {
     inlineDependencies: true,
     esbuild: {
-      target: 'node18',
+      target: 'node20',
       minify: true,
     },
   },
diff --git a/packages/create-vite/package.json b/packages/create-vite/package.json
@@ -20,7 +20,7 @@
     "prepublishOnly": "npm run build"
   },
   "engines": {
-    "node": "^18.0.0 || ^20.0.0 || >=22.0.0"
+    "node": "^20.0.0 || >=22.0.0"
   },
   "repository": {
     "type": "git",
diff --git a/packages/create-vite/tsconfig.json b/packages/create-vite/tsconfig.json
@@ -2,8 +2,8 @@
   "include": ["build.config.ts", "src", "__tests__"],
   "compilerOptions": {
     "outDir": "dist",
-    "target": "ES2022",
-    "module": "ES2020",
+    "target": "ES2023",
+    "module": "Preserve",
     "moduleResolution": "bundler",
     "strict": true,
     "skipLibCheck": true,
diff --git a/packages/plugin-legacy/build.config.ts b/packages/plugin-legacy/build.config.ts
@@ -8,7 +8,7 @@ export default defineBuildConfig({
     emitCJS: true,
     inlineDependencies: true,
     esbuild: {
-      target: 'node18',
+      target: 'node20',
     },
   },
 })
diff --git a/packages/plugin-legacy/package.json b/packages/plugin-legacy/package.json
@@ -29,7 +29,7 @@
     "prepublishOnly": "npm run build"
   },
   "engines": {
-    "node": "^18.0.0 || ^20.0.0 || >=22.0.0"
+    "node": "^20.0.0 || >=22.0.0"
   },
   "repository": {
     "type": "git",
diff --git a/packages/plugin-legacy/tsconfig.json b/packages/plugin-legacy/tsconfig.json
@@ -3,9 +3,9 @@
   "exclude": ["**/*.spec.ts"],
   "compilerOptions": {
     "outDir": "dist",
-    "target": "ES2020",
-    "module": "ES2020",
-    "moduleResolution": "node",
+    "target": "ES2023",
+    "module": "Preserve",
+    "moduleResolution": "bundler",
     "strict": true,
     "declaration": true,
     "sourceMap": true,
diff --git a/packages/vite/package.json b/packages/vite/package.json
@@ -58,7 +58,7 @@
     "types"
   ],
   "engines": {
-    "node": "^18.0.0 || ^20.0.0 || >=22.0.0"
+    "node": "^20.0.0 || >=22.0.0"
   },
   "repository": {
     "type": "git",
@@ -155,7 +155,7 @@
     "ws": "^8.18.2"
   },
   "peerDependencies": {
-    "@types/node": "^18.0.0 || ^20.0.0 || >=22.0.0",
+    "@types/node": "^20.0.0 || >=22.0.0",
     "jiti": ">=1.21.0",
     "less": "*",
     "lightningcss": "^1.21.0",
diff --git a/packages/vite/rollup.config.ts b/packages/vite/rollup.config.ts
@@ -92,7 +92,7 @@ function createSharedNodePlugins({
     nodeResolve({ preferBuiltins: true }),
     esbuild({
       tsconfig: path.resolve(__dirname, 'src/node/tsconfig.json'),
-      target: 'node18',
+      target: 'node20',
       ...esbuildOptions,
     }),
     commonjs({
diff --git a/packages/vite/scripts/dev.ts b/packages/vite/scripts/dev.ts
@@ -19,7 +19,7 @@ writeFileSync(
 const serverOptions: BuildOptions = {
   bundle: true,
   platform: 'node',
-  target: 'node18',
+  target: 'node20',
   sourcemap: true,
   external: [
     ...Object.keys(packageJSON.dependencies),
diff --git a/packages/vite/src/node/__tests__/config.spec.ts b/packages/vite/src/node/__tests__/config.spec.ts
@@ -10,10 +10,7 @@ import { createLogger, mergeConfig } from '../publicUtils'
 
 const [nvMajor, nvMinor] = process.versions.node.split('.').map(Number)
 const isImportAttributesSupported =
-  (nvMajor === 18 && nvMinor >= 20) ||
-  // Node v19 doesn't support import attributes
-  (nvMajor === 20 && nvMinor >= 10) ||
-  nvMajor >= 21
+  (nvMajor === 20 && nvMinor >= 10) || nvMajor >= 21
 
 describe('mergeConfig', () => {
   test('handles configs with different alias schemas', () => {
diff --git a/packages/vite/src/node/plugins/html.ts b/packages/vite/src/node/plugins/html.ts
@@ -1,4 +1,5 @@
 import path from 'node:path'
+import { URL } from 'node:url'
 import type {
   OutputAsset,
   OutputBundle,
@@ -25,7 +26,6 @@ import {
   processSrcSet,
   removeLeadingSlash,
   unique,
-  urlCanParse,
 } from '../utils'
 import type { ResolvedConfig } from '../config'
 import { checkPublicFile } from '../publicDir'
@@ -1006,7 +1006,7 @@ export function buildHtmlPlugin(config: ResolvedConfig): Plugin {
           )
 
           return encodeURIPath(
-            urlCanParse(publicAssetPath)
+            URL.canParse(publicAssetPath)
               ? publicAssetPath
               : normalizePath(publicAssetPath),
           )
diff --git a/packages/vite/src/node/ssr/runtime/__tests__/package.json b/packages/vite/src/node/ssr/runtime/__tests__/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "version": "0.0.0",
   "engines": {
-    "node": "^18.0.0 || ^20.0.0 || >=22.0.0"
+    "node": "^20.0.0 || >=22.0.0"
   },
   "dependencies": {
     "@vitejs/cjs-external": "link:./fixtures/cjs-external",
diff --git a/packages/vite/src/node/tsconfig.json b/packages/vite/src/node/tsconfig.json
@@ -3,9 +3,9 @@
   "include": ["./", "../module-runner", "../types"],
   "exclude": ["**/fixtures"],
   "compilerOptions": {
-    // https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-18
+    // https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-20
     "lib": ["ES2023", "DOM"], // DOM because we have client code that gets inlined via function.toString()
-    "target": "ES2022",
+    "target": "ES2023",
     "skipLibCheck": true, // lib check is done on final types
     "stripInternal": true,
     "paths": {
diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -4,7 +4,7 @@ import net from 'node:net'
 import path from 'node:path'
 import { exec } from 'node:child_process'
 import crypto from 'node:crypto'
-import { URL, fileURLToPath } from 'node:url'
+import { fileURLToPath } from 'node:url'
 import type { ServerOptions as HttpsServerOptions } from 'node:https'
 import { builtinModules, createRequire } from 'node:module'
 import { promises as dns } from 'node:dns'
@@ -240,19 +240,6 @@ function testCaseInsensitiveFS() {
   return fs.existsSync(CLIENT_ENTRY.replace('client.mjs', 'cLiEnT.mjs'))
 }
 
-export const urlCanParse =
-  // eslint-disable-next-line n/no-unsupported-features/node-builtins
-  URL.canParse ??
-  // URL.canParse is supported from Node.js 18.17.0+, 20.0.0+
-  ((path: string, base?: string | undefined): boolean => {
-    try {
-      new URL(path, base)
-      return true
-    } catch {
-      return false
-    }
-  })
-
 export const isCaseInsensitiveFS = testCaseInsensitiveFS()
 
 const VOLUME_RE = /^[A-Z]:/i
@@ -706,12 +693,6 @@ function windowsSafeRealPathSync(path: string): string {
 }
 
 function optimizeSafeRealPathSync() {
-  // Skip if using Node <18.10 due to MAX_PATH issue: https://github.com/vitejs/vite/issues/12931
-  const nodeVersion = process.versions.node.split('.').map(Number)
-  if (nodeVersion[0] < 18 || (nodeVersion[0] === 18 && nodeVersion[1] < 10)) {
-    safeRealpathSync = fs.realpathSync
-    return
-  }
   // Check the availability `fs.realpathSync.native`
   // in Windows virtual and RAM disks that bypass the Volume Mount Manager, in programs such as imDisk
   // get the error EISDIR: illegal operation on a directory
@@ -1023,13 +1004,7 @@ export async function resolveServerUrls(
   } else {
     Object.values(os.networkInterfaces())
       .flatMap((nInterface) => nInterface ?? [])
-      .filter(
-        (detail) =>
-          detail.address &&
-          (detail.family === 'IPv4' ||
-            // @ts-expect-error Node 18.0 - 18.3 returns number
-            detail.family === 4),
-      )
+      .filter((detail) => detail.address && detail.family === 'IPv4')
       .forEach((detail) => {
         let host = detail.address.replace('127.0.0.1', hostname.name)
         // ipv6 host
diff --git a/packages/vite/tsconfig.base.json b/packages/vite/tsconfig.base.json
@@ -1,8 +1,8 @@
 {
   "compilerOptions": {
     "rootDir": ".",
-    "target": "ES2022",
-    "module": "ESNext",
+    "target": "ES2023",
+    "module": "Preserve",
     "moduleResolution": "bundler",
     "strict": true,
     "declaration": true,
diff --git a/playground/ssr-html/test-stacktrace.js b/playground/ssr-html/test-stacktrace.js
@@ -8,19 +8,6 @@ process.setSourceMapsEnabled(isSourceMapEnabled)
 console.log('# sourcemaps enabled:', isSourceMapEnabled)
 console.log('# source file extension:', ext)
 
-const version = (() => {
-  const m = process.version.match(/^v(\d+)\.(\d+)\.\d+$/)
-  if (!m) throw new Error(`Failed to parse version: ${process.version}`)
-
-  return { major: +m[1], minor: +m[2] }
-})()
-
-// https://github.com/nodejs/node/pull/43428
-const isFunctionSourceMapSupported =
-  (version.major === 16 && version.minor >= 17) ||
-  (version.major === 18 && version.minor >= 6) ||
-  version.major >= 19
-
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 const isTest = process.env.VITEST
 
@@ -49,7 +36,7 @@ for (const mod of [abs1, abs2, relative]) {
     // this should not be called
     // when sourcemap support for `new Function` is supported and sourcemap is enabled
     // because the stacktrace is already rewritten by Node.js
-    if (!(isSourceMapEnabled && isFunctionSourceMapSupported)) {
+    if (!isSourceMapEnabled) {
       vite.ssrFixStacktrace(e)
     }
     console.log(e)
diff --git a/playground/tsconfig.json b/playground/tsconfig.json
@@ -3,8 +3,8 @@
   "exclude": ["**/dist/**"],
   "compilerOptions": {
     "checkJs": true,
-    "target": "ES2022",
-    "module": "ESNext",
+    "target": "ES2023",
+    "module": "Preserve",
     "outDir": "dist",
     "baseUrl": ".",
     "allowJs": true,
diff --git a/scripts/tsconfig.json b/scripts/tsconfig.json
@@ -2,9 +2,9 @@
   "$schema": "https://json.schemastore.org/tsconfig",
   "include": ["."],
   "compilerOptions": {
-    "module": "ES2022",
-    "target": "ES2020",
-    "moduleResolution": "node",
+    "module": "Preserve",
+    "target": "ES2023",
+    "moduleResolution": "bundler",
     "strict": true,
     "esModuleInterop": true,
     "skipLibCheck": true,
diff --git a/vitest.config.e2e.ts b/vitest.config.e2e.ts
@@ -22,7 +22,7 @@ export default defineConfig({
     },
   },
   esbuild: {
-    target: 'node18',
+    target: 'node20',
   },
   publicDir: false,
 })
diff --git a/vitest.config.ts b/vitest.config.ts
@@ -21,7 +21,7 @@ export default defineConfig({
     isolate: false,
   },
   esbuild: {
-    target: 'node18',
+    target: 'node20',
   },
   publicDir: false,
   resolve: {
