Skip to content

fix: fix opened model schema resolving issue on spec change #10509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2025
Merged

fix: fix opened model schema resolving issue on spec change #10509

merged 3 commits into from
Jun 26, 2025
+10 −2

Conversation

cka121
Copy link
Contributor

@cka121 cka121 commented Jun 25, 2025 •
edited
Loading

This PR fixes schema resolution issue in case of expanded model during spec chnage.

Description

Fixes #swagger-api/swagger-editor#5420

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

char0n
char0n reviewed Jun 25, 2025
View reviewed changes
char0n
char0n approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise looks good. You'll have to take care of linting issues before the merg.

glowcloud
glowcloud approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cka121 cka121 merged commit 0ddc74d into master Jun 26, 2025
8 checks passed
@char0n
Copy link
Contributor

char0n commented Jun 26, 2025 •
edited
Loading

0ddc74d#diff-a7f1b7ddc7dd4885ae3779d98facef5572184ed0b1f50b0fd896955a683a75a9R67 - looks like a bug

schemapath already contains schemaName but we're assigning it again on that line.

I've overlooked it during the review, sorry.

UPDATE: disregard. schemasPath vs schemaPath. Two different variable names

swagger-bot pushed a commit that referenced this pull request Jun 26, 2025
@semantic-release-bot
chore(release): cut the 5.25.3 release
90805ee 
## [5.25.3](v5.25.2...v5.25.3) (2025-06-26)

### Bug Fixes

* fix opened model schema resolving issue on spec change ([#10509](#10509)) ([0ddc74d](0ddc74d))
@swagger-bot
Copy link
Contributor

🎉 This PR is included in version 5.25.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glowcloud glowcloud glowcloud approved these changes

+1 more reviewer

@char0n char0n char0n approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
released type: bug version: 5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cka121 @char0n @swagger-bot @glowcloud @ShikhaSaboo