Skip to content

Conversation

tinaselenge
Copy link
Contributor

Type of change

Select the type of your PR

  • Enhancement / new feature

Description

  • Add a method for creating admin client for controllers with BOOTSTRAP_CONTROLLERS_CONFIG set.
  • Make KafkaRoller create admin client against controllers nodes before attempting to roll a controller node
  • Tidy up: remove ceShouldBeFatal option as it's never set to true.

There will be a follow up PR to dynamically apply configurations for controllers using the admin client instead of how we currently restart controllers when any config changes.

Closes #9692

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@ppatierno ppatierno added this to the 0.49.0 milestone Sep 8, 2025
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. How risky do you think it is? Can we merge it shortly before new release if it passes the other reviews as well?

@scholzj
Copy link
Member

scholzj commented Sep 10, 2025

/gha run pipeline=regression,upgrade

Copy link

⏳ System test verification started: link

@scholzj
Copy link
Member

scholzj commented Sep 10, 2025

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member

scholzj commented Sep 10, 2025

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

❌ System test verification failed: link

Copy link

🎉 System test verification passed: link

@tinaselenge
Copy link
Contributor Author

I think this looks good. How risky do you think it is? Can we merge it shortly before new release if it passes the other reviews as well?

Given that I had to revert this change once already (due to an AdminClient bug that is fixed now), and resulted in delaying the release , I am happy for it to get merged after the release :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KRaft]: Allow KafkaRoller directly connect to controllers
3 participants