-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Allow KafkaRoller connect to controllers #11838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Gantigmaa Selenge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. How risky do you think it is? Can we merge it shortly before new release if it passes the other reviews as well?
/gha run pipeline=regression,upgrade |
⏳ System test verification started: link |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run upgrade |
Azure Pipelines successfully started running 1 pipeline(s). |
❌ System test verification failed: link |
🎉 System test verification passed: link |
Given that I had to revert this change once already (due to an AdminClient bug that is fixed now), and resulted in delaying the release , I am happy for it to get merged after the release :D |
Type of change
Select the type of your PR
Description
There will be a follow up PR to dynamically apply configurations for controllers using the admin client instead of how we currently restart controllers when any config changes.
Closes #9692
Checklist
Please go through this checklist and make sure all applicable tasks have been done