Add PR trigger to verify changes in sts workflow for every change (#11833)

Signed-off-by: Jakub Stejskal <[email protected]>

Author: Frawless

.github/actions/systemtests/parse-comment/action.yml

@@ -13,7 +13,7 @@ inputs:
   profile:
     description: "Comma-separated or single profile name(s)"
     required: false
-    default: ""
+    default: "smoke"
 
 outputs:
   pipelineList:
@@ -73,6 +73,9 @@ runs:
 
           if (ev === 'workflow_dispatch') {
             shouldRun = true;
+          } else if (ev === 'pull_request') {
+            // Auto-run smoke tests on PR workflow changes
+            shouldRun = true;
           } else if (ev === 'issue_comment' && context.payload?.issue?.pull_request) {
             shouldRun = /^\s*\/gha\s+run\b/i.test(body || '');
           }
@@ -89,7 +92,8 @@ runs:
       with:
         script: |
           const body = context.payload?.comment?.body ?? '';
-          const fallback = `/gha run profile=${process.env.INPUT_PROFILE} kafkaVersion=${process.env.INPUT_KAFKA_VERSION}`;
+          const profile = process.env.INPUT_PROFILE || 'smoke';
+          const fallback = `/gha run profile=${profile} kafkaVersion=${process.env.INPUT_KAFKA_VERSION}`;
           const builtComment = (body && body.trim().length) ? body : fallback;
           
           core.setOutput('builtComment', builtComment);

.github/actions/utils/set-defaults/action.yml

@@ -17,12 +17,13 @@ runs:
         echo "TAG=$GITHUB_REF_NAME" >> $GITHUB_ENV
         
         # Check if we're in a pull request context
-        if [[ "${{ github.event.issue.pull_request }}" != "" && "${{ github.event.issue.pull_request }}" != "null" ]]; then
+        if [[ "${{ github.event.issue.pull_request }}" != "" && "${{ github.event.issue.pull_request }}" != "null" ]] || [[ "${{ github.event_name }}" == "pull_request" ]]; then
           echo "Detected: Pull Request"
           
           echo "PULL_REQUEST=true" >> $GITHUB_ENV
           echo "DOCKER_ORG=strimzi" >> $GITHUB_ENV
           echo "TAG=pr" >> $GITHUB_ENV
+          # For PR events, preserve the DOCKER_REGISTRY set by setup-kind (Kind registry)
         else
           # Not a PR - use standard Strimzi settings
           echo "PULL_REQUEST=false" >> $GITHUB_ENV

.github/tests/scenarios/parse-comment.yaml

@@ -207,7 +207,7 @@ scenarios:
     fixture: .github/tests/events/parse-comment/dispatch_empty.json
     expectations:
       pipelines: ""
-      profiles: "operators,operands,brokers-and-security,azp_kraft_upgrade,azp_kafka_upgrade"
+      profiles: "smoke"
       strimzi_feature_gates: ""
       strimzi_rbac_scope: ""
       cluster_operator_install_type: "yaml"

.github/workflows/system-tests.yml

@@ -20,6 +20,12 @@ on:
   # Automated trigger for issue comment
   issue_comment:
     types: [created]
+  # Testing trigger for PRs - tests workflow changes
+  pull_request:
+    types: [opened, synchronize]
+    paths:
+      - '.github/workflows/run-system-tests.yml'
+      - '.github/workflows/system-tests.yml'
 
 permissions:
   contents: read
@@ -69,7 +75,7 @@ jobs:
   check-rights:
     needs:
       - parse-params
-    if: ${{ needs.parse-params.outputs.shouldRun == 'true' }}
+    if: ${{ needs.parse-params.outputs.shouldRun == 'true' && github.event_name != 'pull_request' }}
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -99,7 +105,7 @@ jobs:
       - parse-params
       - check-rights
     # Run only if properly triggered, permissions check passed, and the run is not for release (already built images)
-    if: ${{ needs.parse-params.outputs.shouldRun == 'true' && needs.check-rights.result == 'success' && needs.parse-params.outputs.releaseVersion == 'latest' }}
+    if: ${{ always() && needs.parse-params.outputs.shouldRun == 'true' && (needs.check-rights.result == 'success' || github.event_name == 'pull_request') && needs.parse-params.outputs.releaseVersion == 'latest' }}
     runs-on: oracle-2cpu-8gb-arm64
     steps:
       - uses: actions/checkout@v5
@@ -117,7 +123,7 @@ jobs:
       - check-rights
       - build-artifacts
     # Run only if properly triggered, permissions check passed, and the run is not for release (already built images)
-    if: ${{ needs.parse-params.outputs.shouldRun == 'true' && needs.check-rights.result == 'success' && needs.parse-params.outputs.releaseVersion == 'latest' && needs.build-artifacts.result != 'failure'}}
+    if: ${{ always() && needs.parse-params.outputs.shouldRun == 'true' && (needs.check-rights.result == 'success' || github.event_name == 'pull_request') && needs.parse-params.outputs.releaseVersion == 'latest' && needs.build-artifacts.result != 'failure'}}
     strategy:
       matrix:
         architecture: [amd64, arm64]
@@ -139,7 +145,7 @@ jobs:
       - build-artifacts
       - build-images
     # Run if properly triggered, permissions check passed, and build jobs succeeded or were skipped
-    if: ${{ always() && needs.parse-params.outputs.shouldRun == 'true' && needs.check-rights.result == 'success' && needs.build-images.result != 'failure' &&  needs.build-artifacts.result != 'failure' }}
+    if: ${{ always() && needs.parse-params.outputs.shouldRun == 'true' && (needs.check-rights.result == 'success' || github.event_name == 'pull_request') && needs.build-images.result != 'failure' &&  needs.build-artifacts.result != 'failure' }}
     # Job needs write rights for setting statuses on pull-requests
     permissions:
       contents: read
@@ -166,7 +172,7 @@ jobs:
       - parse-params
       - check-rights
       - run-tests
-    if: ${{ always() && needs.parse-params.outputs.shouldRun == 'true' && needs.check-rights.result == 'success' }}
+    if: ${{ always() && needs.parse-params.outputs.shouldRun == 'true' && needs.check-rights.result == 'success' && github.event_name != 'pull_request' }}
     runs-on: ubuntu-latest
     permissions:
       contents: read