make UnusedImport an error; update test summaries (#3687)

* make UnusedImport an error; update test summaries

* std/cmdline is only used when isMainModule

* std/os is only used when isMainModule

* more import cleanups

Author: tersec

GeneralStateTestsDevnet.md

@@ -139,11 +139,6 @@ OK: 5/5 Fail: 0/5 Skip: 0/5
 + valid_multi_inf.json                                            OK
 ```
 OK: 6/6 Fail: 0/6 Skip: 0/6
-## bls12_precompiles_before_fork
-```diff
-+ precompile_before_fork.json                                     OK
-```
-OK: 1/1 Fail: 0/1 Skip: 0/1
 ## bls12_variable_length_input_contracts
 ```diff
 + invalid_gas_g1msm.json                                          OK
@@ -466,10 +461,9 @@ OK: 50/50 Fail: 0/50 Skip: 0/50
 + pointer_to_precompile.json                                      OK
 + pointer_to_static.json                                          OK
 + pointer_to_static_reentry.json                                  OK
-+ set_code_type_tx_pre_fork.json                                  OK
 + static_to_pointer.json                                          OK
 ```
-OK: 16/16 Fail: 0/16 Skip: 0/16
+OK: 15/15 Fail: 0/15 Skip: 0/15
 ## shift_combinations
 ```diff
 + combinations.json                                               OK
@@ -557,4 +551,4 @@ OK: 2/2 Fail: 0/2 Skip: 0/2
 OK: 1/1 Fail: 0/1 Skip: 0/1
 
 ---TOTAL---
-OK: 267/267 Fail: 0/267 Skip: 0/267
+OK: 265/265 Fail: 0/265 Skip: 0/265

config.nims

@@ -158,6 +158,7 @@ if canEnableDebuggingSymbols:
 --define:nimOldCaseObjects # https://github.com/status-im/nim-confutils/issues/9
 
 switch("warningAsError", "BareExcept:on")
+switch("warningAsError", "UnusedImport:on")
 switch("hintAsError", "ConvFromXtoItselfNotNeeded:on")
 switch("hintAsError", "DuplicateModuleImport:on")
 

tests/eest/eest_engine.nim

@@ -7,11 +7,9 @@
 # This file may not be copied, modified, or distributed except according to
 # those terms.
 
-{.push raises: [].}
+{.push raises: [], gcsafe.}
 
 import
-  std/[cmdline, os],
-  unittest2,
   eth/common/headers_rlp,
   web3/eth_api_types,
   web3/engine_api_types,
@@ -107,9 +105,13 @@ proc processFile*(fileName: string): bool =
   return testPass
 
 when isMainModule:
+  import
+    std/[cmdline, os],
+    unittest2
+
   if paramCount() == 0:
     let testFile = getAppFilename().splitPath().tail
     echo "Usage: " & testFile & " vector.json"
     quit(QuitFailure)
 
-  check processFile(paramStr(1))
+  check processFile(paramStr(1))

tests/eest/eest_engine_test.nim

@@ -7,10 +7,10 @@
 # This file may not be copied, modified, or distributed except according to
 # those terms.
 
-{.push raises: [].}
+{.push raises: [], gcsafe.}
 
 import
-  std/[os, osproc],
+  std/os,
   unittest2,
   ./eest_helpers,
   ./eest_engine
@@ -32,4 +32,4 @@ runEESTSuite(
   skipFiles,
   baseFolder,
   eestType
-)
+)