Skip to content

Commit c69c01b

Browse files
committed
reloader: Add in support for dnsConfig for pod reloader. This is supported as a common standard in most public helm charts, so decided to create a PR here.
1 parent 9e33dac commit c69c01b

File tree

4 files changed

+20
-3
lines changed

4 files changed

+20
-3
lines changed

deployments/kubernetes/chart/reloader/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v1
22
name: reloader
33
description: Reloader chart that runs on kubernetes
4-
version: 2.2.0
4+
version: 2.2.1
55
appVersion: v1.4.6
66
keywords:
77
- Reloader

deployments/kubernetes/chart/reloader/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ helm uninstall {{RELEASE_NAME}} -n {{NAMESPACE}}
6767
### Deployment Reloader Parameters
6868

6969
| Parameter | Description | Type | Default |
70-
| ----------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------- | ------ | ----------------- |
70+
|-------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------|--------|-------------------|
7171
| `reloader.deployment.replicas` | Number of replicas, if you wish to run multiple replicas set `reloader.enableHA = true`. The replicas will be limited to 1 when `reloader.enableHA = false` | int | 1 |
7272
| `reloader.deployment.revisionHistoryLimit` | Limit the number of revisions retained in the revision history | int | 2 |
7373
| `reloader.deployment.nodeSelector` | Scheduling pod to a specific node based on set labels | map | `{}` |
@@ -84,7 +84,7 @@ helm uninstall {{RELEASE_NAME}} -n {{NAMESPACE}}
8484
| `reloader.deployment.resources` | Set container requests and limits (e.g. CPU or memory) | map | `{}` |
8585
| `reloader.deployment.pod.annotations` | Set annotations for pod | map | `{}` |
8686
| `reloader.deployment.priorityClassName` | Set priority class for pod in cluster | string | `""` |
87-
87+
| `reloader.deployment.dnsConfig` | dns configuration for pods | map | `{}` |
8888
### Other Reloader Parameters
8989

9090
| Parameter | Description | Type | Default |

deployments/kubernetes/chart/reloader/templates/deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ spec:
7171
{{- if .Values.reloader.deployment.priorityClassName }}
7272
priorityClassName: {{ .Values.reloader.deployment.priorityClassName }}
7373
{{- end }}
74+
{{- with .Values.reloader.deployment.dnsConfig }}
75+
dnsConfig:
76+
{{- toYaml . | nindent 8 }}
77+
{{- end }}
7478
containers:
7579
{{- if .Values.global.imageRegistry }}
7680
- image: "{{ .Values.global.imageRegistry }}/{{ .Values.image.name }}:{{ .Values.image.tag }}"

deployments/kubernetes/chart/reloader/values.yaml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,19 @@ reloader:
5353
# Set to true to expose a prometheus counter of reloads by namespace (this metric may have high cardinality in clusters with many namespaces)
5454
enableMetricsByNamespace: false
5555
deployment:
56+
# Specifies the deployment DNS configuration.
57+
dnsConfig: {}
58+
# nameservers:
59+
# - 1.2.3.4
60+
# searches:
61+
# - ns1.svc.cluster-domain.example
62+
# - my.dns.search.suffix
63+
# options:
64+
# - name: ndots
65+
# value: "1"
66+
# - name: attempts
67+
# value: "3"
68+
5669
# If you wish to run multiple replicas set reloader.enableHA = true
5770
replicas: 1
5871

0 commit comments

Comments
 (0)