Skip to content

Commit 2e68364

Browse files
authored
[ENHANCE] #639 , Add resources to the Reloader deployment. (#692)
* issue-639 , adding Resources to the values.yaml * revert old change * adding resources in helm template command * add resources to reloader.yaml file only * Update readme about the default resource limit and request values * fix lint error * fix lint error
1 parent 0ab949f commit 2e68364

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

.github/workflows/push.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,12 @@ jobs:
211211

212212
- name: Helm Template
213213
run: |
214-
helm template reloader deployments/kubernetes/chart/reloader/ > deployments/kubernetes/reloader.yaml
214+
helm template reloader deployments/kubernetes/chart/reloader/ \
215+
--set reloader.deployment.resources.limits.cpu=150m \
216+
--set reloader.deployment.resources.limits.memory=512Mi \
217+
--set reloader.deployment.resources.requests.cpu=10m \
218+
--set reloader.deployment.resources.requests.memory=128Mi > deployments/kubernetes/reloader.yaml
219+
215220
helm template reloader deployments/kubernetes/chart/reloader/ --output-dir deployments/kubernetes/manifests && mv deployments/kubernetes/manifests/reloader/templates/* deployments/kubernetes/manifests/ && rm -r deployments/kubernetes/manifests/reloader
216221
217222
- name: Remove labels and annotations from manifests

README.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,17 @@ You can apply vanilla manifests by changing `RELEASE-NAME` placeholder provided
190190
kubectl apply -f https://raw.githubusercontent.com/stakater/Reloader/master/deployments/kubernetes/reloader.yaml
191191
```
192192

193-
By default, Reloader gets deployed in `default` namespace and watches changes `secrets` and `configmaps` in all namespaces.
193+
By default, Reloader gets deployed in `default` namespace and watches changes `secrets` and `configmaps` in all namespaces.Additionally, in the default Reloader deployment, the following resource limits and requests are set:
194+
195+
```yaml
196+
resources:
197+
limits:
198+
cpu: 150m
199+
memory: 512Mi
200+
requests:
201+
cpu: 10m
202+
memory: 128Mi
203+
```
194204

195205
Reloader can be configured to ignore the resources `secrets` and `configmaps` by passing the following arguments (`spec.template.spec.containers.args`) to its container :
196206

0 commit comments

Comments
 (0)