Undefined Offset notice during live coding of arrow functions #2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/tokenizer-bug-php-74-arrow-functions
branch
3 times, most recently
from
56a04a6 to
332e094
Compare
…ow functions Defensive coding for the arrow functions backfill. This fixes a number of "undefined index" PHP notices when arrow functions are being declared during live coding. ``` Notice: Undefined offset: 561 in /path/to/PHP_CodeSniffer/src/Tokenizers/PHP.php on line 1807 Notice: Undefined offset: 561 in /path/to/PHP_CodeSniffer/src/Tokenizers/PHP.php on line 1808 Notice: Undefined offset: 561 in /path/to/PHP_CodeSniffer/src/Tokenizers/PHP.php on line 1815 ``` It also fixes a bug where an inner for loop was using the wrong variable for the condition part. Includes adjusted unit test + additional unit test covering all changes. Includes minor documentation fix.
ghost
reviewed
Jan 14, 2020
| } | ||
|
|
||
| if ($this->tokens[$x]['code'] === T_OPEN_PARENTHESIS) { | ||
| if (isset($this->tokens[$x]) === true && $this->tokens[$x]['code'] === T_OPEN_PARENTHESIS) { |
There was a problem hiding this comment.
isset Always returns bool. === true is redundant and should be removed.
There was a problem hiding this comment.
@tvanrielwendrich While that is true, the PHPCS native code style rules demands the === true, so no, this cannot be removed.
gsherwood
changed the title
|
Thanks |
tobias-trozowski
pushed a commit
to tobias-trozowski/PHP_CodeSniffer
that referenced
this pull request
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defensive coding for the arrow functions backfill. This fixes a number of "undefined index" PHP notices when arrow functions are being declared during live coding.
It also fixes a bug where an inner for loop was using the wrong variable for the condition part.
Includes unit test.