Merge pull request #663 from slok/slok/prepare-v0130

Prepare for v0.13.0

Author: slok

CHANGELOG.md

@@ -9,7 +9,8 @@
 - Core SLO validation and SLO rules generation migrated to SLO plugins.
 - (BREAKING) `--sli-plugins-path`, `--slo-plugins-path`, `-m` args and it's env vars `SLOTH_SLI_PLUGINS_PATH`and  `SLOTH_SLO_PLUGINS_PATH` have been removed in favor or `--plugins-path`, `-p` and it's env var `SLOTH_PLUGINS_PATH` that discovers and loads SLI and SLO plugins with a single flag.
 - Simplify validation and improve validation message by using custom logic instead of `go-playground/validator`.
-- (BREAKING) `--disable-optimized-rules` flag and associated env var  has been removed.
+- (BREAKING) `--disable-optimized-rules` flag and associated env var has been removed.
+- (BREAKING) Helm chart has removed the option for disabling optimized rules.
 - Update to Kubernetes v1.34.
 - Update to Go v1.25.
 

deploy/kubernetes/helm/sloth/templates/deployment.yaml

@@ -61,9 +61,6 @@ spec:
             {{- with .Values.sloth.defaultSloPeriod }}
             - --default-slo-period={{ . }}
             {{- end }}
-            {{- if not .Values.sloth.optimizedRules }}
-            - --disable-optimized-rules
-            {{- end }}
             {{- if .Values.customSloConfig.enabled }}
             - --slo-period-windows-path={{ .Values.customSloConfig.path }}
             {{- end }}

deploy/kubernetes/helm/sloth/tests/testdata/output/deployment_custom.yaml

@@ -52,7 +52,6 @@ spec:
             - --extra-labels=k1=v1
             - --extra-labels=k2=v2
             - --plugins-path=/plugins
-            - --disable-optimized-rules
             - --logger=default
           ports:
             - containerPort: 8081

deploy/kubernetes/helm/sloth/tests/testdata/output/deployment_custom_no_extras.yaml

@@ -51,7 +51,6 @@ spec:
             - --label-selector=x=y,z!=y
             - --extra-labels=k1=v1
             - --extra-labels=k2=v2
-            - --disable-optimized-rules
             - --logger=default
           securityContext:
             allowPrivilegeEscalation: false

deploy/kubernetes/helm/sloth/tests/testdata/output/deployment_custom_slo_config.yaml

@@ -52,7 +52,6 @@ spec:
             - --label-selector=x=y,z!=y
             - --extra-labels=k1=v1
             - --extra-labels=k2=v2
-            - --disable-optimized-rules
             - --slo-period-windows-path=/windows
             - --logger=default
           ports:

deploy/kubernetes/helm/sloth/tests/testdata/output/deployment_default.yaml

@@ -32,7 +32,7 @@ spec:
       serviceAccountName: sloth
       containers:
         - name: sloth
-          image: ghcr.io/slok/sloth:v0.12.0
+          image: ghcr.io/slok/sloth:v0.13.0
           args:
             - kubernetes-controller
             - --plugins-path=/plugins

deploy/kubernetes/helm/sloth/tests/values_test.go

@@ -27,7 +27,6 @@ func customValues() msi {
 			"workers":        99,
 			"labelSelector":  `x=y,z!=y`,
 			"namespace":      "somens",
-			"optimizedRules": false,
 			"extraLabels": msi{
 				"k1": "v1",
 				"k2": "v2",

deploy/kubernetes/helm/sloth/values.yaml

@@ -6,7 +6,7 @@ labels: {}
 image:
   registry: ghcr.io # This field cannot be empty if global.imageRegistry is also empty.
   repository: slok/sloth
-  tag: v0.12.0
+  tag: v0.13.0
 
 # -- Container resources: requests and limits for CPU, Memory
 resources:
@@ -28,7 +28,6 @@ sloth:
   namespace: ""         # The namespace where sloth will the CRs to process.
   extraLabels: {}       # Labels that will be added to all the generated SLO Rules.
   defaultSloPeriod: ""  # The slo period used by sloth (e.g. 30d).
-  optimizedRules: true  # Reduce prom load for calculating period window burnrates.
   debug:
     enabled: false
   # Could be: default or json

deploy/kubernetes/raw/sloth-with-common-plugins.yaml

@@ -85,7 +85,7 @@ spec:
       serviceAccountName: sloth
       containers:
         - name: sloth
-          image: ghcr.io/slok/sloth:v0.12.0
+          image: ghcr.io/slok/sloth:v0.13.0
           args:
             - kubernetes-controller
             - --plugins-path=/plugins

deploy/kubernetes/raw/sloth.yaml

@@ -85,7 +85,7 @@ spec:
       serviceAccountName: sloth
       containers:
         - name: sloth
-          image: ghcr.io/slok/sloth:v0.12.0
+          image: ghcr.io/slok/sloth:v0.13.0
           args:
             - kubernetes-controller
             - --logger=default