fix confirmation error using async await (change target to ES2017)

Author: olmobrutall

Signum.React.Extensions/Workflow/Case/CaseFrameModal.tsx

@@ -179,16 +179,17 @@ export default class CaseFrameModal extends React.Component<CaseFrameModalProps,
       allowExchangeEntity: false,
       prefix: this.prefix,
       isExecuting: () => this.state.executing == true,
-      execute: action => {
+      execute: async action => {
         if (this.state.executing)
           return;
 
         this.setState({ executing: true });
-        action()
-          .finally(() => this.setState({ executing: undefined }))
-          .done();
+        try {
+          await action();
+        } finally {
+          this.setState({ executing: undefined });
+        }
       }
-
     };
 
     var activityPack = { entity: pack.activity, canExecute: pack.canExecuteActivity };
@@ -243,15 +244,16 @@ export default class CaseFrameModal extends React.Component<CaseFrameModalProps,
       allowExchangeEntity: false,
       prefix: this.prefix,
       isExecuting: () => this.state.executing == true,
-      execute: action => {
+      execute: async action => {
         if (this.state.executing)
           return;
 
         this.setState({ executing: true });
-
-        action()
-          .finally(() => this.setState({ executing: undefined }))
-          .done();
+        try {
+          await action();
+        } finally {
+          this.setState({ executing: undefined })
+        }
       }
     };
 

Signum.React.Extensions/Workflow/Case/CaseFramePage.tsx

@@ -164,14 +164,16 @@ export default class CaseFramePage extends React.Component<CaseFramePageProps, C
       allowExchangeEntity: false,
       prefix: "caseFrame",
       isExecuting: () => this.state.executing == true,
-      execute: action => {
+      execute: async action => {
         if (this.state.executing)
           return;
 
         this.setState({ executing: true });
-        action()
-          .finally(() => { this.setState({ executing: undefined }) })
-          .done();
+        try {
+          await action();
+        } finally {
+          this.setState({ executing: undefined });
+        }
       }
     };
 
@@ -245,14 +247,16 @@ export default class CaseFramePage extends React.Component<CaseFramePageProps, C
       allowExchangeEntity: false,
       prefix: "caseFrame",
       isExecuting: () => this.state.executing == true,
-      execute: action => {
+      execute: async action => {
         if (this.state.executing)
           return;
 
         this.setState({ executing: true });
-        action()
-          .finally(() => this.setState({ executing: undefined }))
-          .done();
+        try {
+          await action();
+        } finally {
+          this.setState({ executing: undefined });
+        }
       }
     };
 

Signum.React.Extensions/tsconfig.json

@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2017",
     "sourceMap": true,
     "module": "esnext",
     "moduleResolution": "node",

Signum.React/Scripts/Frames/FrameModal.tsx

@@ -265,18 +265,19 @@ export const FrameModal = React.forwardRef(function FrameModal(p: FrameModalProp
       allowExchangeEntity: p.buttons == "close" && (p.allowExchangeEntity ?? true),
       prefix: prefix,
       isExecuting: () => pc.executing == true,
-      execute: action => {
+      execute: async action => {
         if (pc.executing)
           return;
 
         pc.executing = true;
         forceUpdate();
-        action()
-          .finally(() => {
-            pc.executing = undefined;
-            forceUpdate();
-          })
-          .done();
+        try {
+          await action();
+
+        } finally {
+          pc.executing = undefined;
+          forceUpdate();
+        }
       }
     };
 

Signum.React/Scripts/Frames/FramePage.tsx

@@ -182,14 +182,18 @@ export default function FramePage(p: FramePageProps) {
     entityComponent: entityComponent.current,
     pack: state.pack,
     isExecuting: () => state.executing == true,
-    execute: action => {
+    execute: async action => {
       if (state.executing)
         return;
 
       state.executing = true;
       forceUpdate();
-      action()
-        .finally(() => { state.executing = undefined; forceUpdate(); }).done();
+      try {
+        await action();
+      } finally {
+        state.executing = undefined;
+        forceUpdate();
+      }
     },
     onReload: (pack, reloadComponent, callback) => {
 

Signum.React/Scripts/Operations.tsx

@@ -410,7 +410,7 @@ export class EntityOperationContext<T extends Entity> {
         return this.settings.onClick(this);
       else
         return defaultOnClick(this);
-    });
+    }).done();
   }
 
   textOrNiceName() {

Signum.React/Scripts/Reflection.ts

@@ -892,7 +892,7 @@ export function createBinding(parentValue: any, lambdaMembers: LambdaMember[]):
 
 
 const functionRegex = /^function\s*\(\s*([$a-zA-Z_][0-9a-zA-Z_$]*)\s*\)\s*{\s*(\"use strict\"\;)?\s*(var [^;]*;)?\s*return\s*([^;]*)\s*;?\s*}$/;
-const lambdaRegex = /^\s*\(?\s*([$a-zA-Z_][0-9a-zA-Z_$]*)\s*\)?\s*=>\s*{?\s*(return\s+)?([^;]*)\s*;?\s*}?$/;
+const lambdaRegex = /^\s*\(?\s*([$a-zA-Z_][0-9a-zA-Z_$]*)\s*\)?\s*=>(\s*{?\s*(return\s+)?([^;]*)\s*;?\s*}?)$/;
 const memberRegex = /^(.*)\.([$a-zA-Z_][0-9a-zA-Z_$]*)$/;
 const memberIndexerRegex = /^(.*)\["([$a-zA-Z_][0-9a-zA-Z_$]*)"\]$/;
 const mixinMemberRegex = /^(.*)\.mixins\["([$a-zA-Z_][0-9a-zA-Z_$]*)"\]$/; //Necessary for some crazy minimizers

Signum.React/Scripts/TypeContext.ts

@@ -493,7 +493,7 @@ export interface EntityFrame {
   allowExchangeEntity: boolean;
 
   isExecuting(): boolean; 
-  execute: (action: () => Promise<void>) => void;
+  execute: (action: () => Promise<void>) => Promise<void>;
 
   createNew?: (oldPack: EntityPack<ModifiableEntity>) => (Promise<EntityPack<ModifiableEntity> | undefined>) | undefined;
   prefix: string;

Signum.React/tsconfig.json

@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "es5",
+    "target": "ES2017",
     "sourceMap": false,
     "module": "esnext",
     "moduleResolution": "node",