fix: apply 'ro' flag to iso9660 filesystems

Fixes #11807

Signed-off-by: Mateusz Urbanek <[email protected]>

Author: shanduur

internal/app/machined/pkg/runtime/v1alpha1/platform/metal/metal.go

@@ -180,7 +180,6 @@ func readConfigFromISO(ctx context.Context, r state.State) ([]byte, error) {
 		mount.WithFsopen(
 			volumeStatus.TypedSpec().Filesystem.String(),
 			fsopen.WithSource(volumeStatus.TypedSpec().MountLocation),
-			fsopen.WithBoolParameter("ro"),
 			fsopen.WithPrinter(log.Printf),
 		),
 	)

internal/pkg/xfs/fsopen/fsopen_linux.go

@@ -52,13 +52,25 @@ func New(fstype string, opts ...Option) *FS {
 		binaryParams: make(map[string][][]byte),
 	}
 
-	for _, opt := range opts {
+	for _, opt := range defaultOpts(fstype, opts...) {
 		opt.set(fs)
 	}
 
 	return fs
 }
 
+// defaultOpts applies default options for filesystems.
+func defaultOpts(fstype string, opts ...Option) []Option {
+	if fstype == "iso9660" {
+		opts = append(
+			opts,
+			WithBoolParameter("ro"),
+		)
+	}
+
+	return opts
+}
+
 // Open initializes the filesystem and returns the file descriptor for the mounted filesystem.
 // If the filesystem is already created, it returns the existing file descriptor.
 // This method is idempotent, meaning it can be called multiple times without side effects.