Skip to content

Commit ac0fcdf

Browse files
committed
⚠ Warn when importing from legacy ss:// links
1 parent a28efee commit ac0fcdf

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

CHANGES

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
4.4.0.0 2021-01-01
22
- Security: remove infrastructure of stream ciphers (#3048)
3+
- Show warning message when importing from deprecated legacy ss:// links.
34
- Other minor bug fixes and improvements
45

56
4.3.3.0 2020-12-07

shadowsocks-csharp/Controller/ShadowsocksController.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,8 @@ public bool AddServerBySSURL(string ssURL)
450450
foreach (var server in servers)
451451
{
452452
_config.configs.Add(server);
453+
if (server.warnLegacyUrl)
454+
MessageBox.Show(I18N.GetString("Warning: importing {0} from a legacy ss:// link. Support for legacy ss:// links will be dropped in version 5. Make sure to update your ss:// links.", server.ToString()));
453455
}
454456
_config.index = _config.configs.Count - 1;
455457
SaveConfig(_config);

shadowsocks-csharp/Data/i18n.csv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ Failed to update registry,Не удалось обновить запись в
133133
Import from URL: {0} ?,импортировать из адреса: {0} ?,从URL导入: {0} ?,從URL匯入: {0} ?,{0}:このURLからインポートしますか?,,
134134
Successfully imported from {0},Успешно импортировано из {0},导入成功:{0},導入成功:{0},{0}:インポートしました。,,
135135
Failed to import. Please check if the link is valid.,,导入失败,请检查链接是否有效。,導入失敗,請檢查鏈接是否有效。,インポートに失敗しました。リンクの有効性を確認してください。,,
136+
Warning: importing {0} from a legacy ss:// link. Support for legacy ss:// links will be dropped in version 5. Make sure to update your ss:// links.,,警告: 正在从旧版 ss:// 链接导入 {0}。对旧版 ss:// 链接的支持将于 v5 移除,请及时更新你的链接。,,,,
136137
System Proxy On: ,Системный прокси:,系统代理已启用:,系統 Proxy 已啟用:,システム プロキシが有効:,시스템 프록시 활성화됨: ,Proxy système activé:
137138
Running: Port {0},Запущен на порту {0},正在运行:端口 {0},正在執行:連接埠號碼 {0},実行中:ポート {0},실행 중: 포트 {0}번,En cours d'exécution: port {0}
138139
"Unexpected error, shadowsocks will exit. Please report to","Непредвиденная ошибка, пожалуйста сообщите на",非预期错误,Shadowsocks将退出。请提交此错误到,非預期錯誤,Shadowsocks 將結束。請報告此錯誤至,予想外のエラーが発生したため、Shadowsocks を終了します。詳しくは下記までお問い合わせ下さい:,알 수 없는 오류로 Shadowsocks가 종료될 것입니다. 오류를 여기로 제보해주세요:,Shadowsocks va quitter en présence d/érreur inattendue. Veuillez signaler à

shadowsocks-csharp/Model/Server.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ public class Server
2929
public int server_port;
3030
public string password;
3131
public string method;
32-
33-
34-
35-
3632
// optional fields
3733
[DefaultValue("")]
3834
[JsonProperty(NullValueHandling = NullValueHandling.Ignore, DefaultValueHandling = DefaultValueHandling.IgnoreAndPopulate)]
@@ -53,6 +49,9 @@ public class Server
5349

5450
public int timeout;
5551

52+
// Set to true when imported from a legacy ss:// URL.
53+
public bool warnLegacyUrl;
54+
5655
public override int GetHashCode()
5756
{
5857
return server.GetHashCode() ^ server_port;
@@ -177,6 +176,7 @@ private static Server ParseLegacyURL(string ssURL)
177176
server.password = details.Groups["password"].Value;
178177
server.server = details.Groups["hostname"].Value;
179178
server.server_port = int.Parse(details.Groups["port"].Value);
179+
server.warnLegacyUrl = true;
180180
return server;
181181
}
182182

0 commit comments

Comments
 (0)