-
Notifications
You must be signed in to change notification settings - Fork 328
Remove version from dockerfile rhel10 #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[test] |
Testing Farm results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found one possible improvement in the template logic.
But let me open a broader discussion: What do we need the version label and version ENV variable for? I look at the history, and these versions are the same for many years now without any single change and they are just copy-pasted over and over.
@pkubatrh I saw your comment that we should keep the ENV version so you might know why we need it.
Version label - used to version the image. Historically required by the build system and used as part of the builds NVR. Usually set to |
Thanks for the context @pkubatrh ! Let's finish this PR, and I'll open a new one where I try to remove them both together with the associated logic, and we'll see what happens. |
Konflux build pipeline needs it. See https://issues.redhat.com/browse/RHELMISC-17288 Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
130805c
to
8224cf6
Compare
[test] |
Remove 'version' label from Dockerfile.rhel10
Konflux build pipeline needs it.
See https://issues.redhat.com/browse/RHELMISC-17288