Skip to content

Conversation

phracek
Copy link
Member

@phracek phracek commented Sep 11, 2025

Remove 'version' label from Dockerfile.rhel10

Konflux build pipeline needs it.
See https://issues.redhat.com/browse/RHELMISC-17288

@phracek
Copy link
Member Author

phracek commented Sep 11, 2025

[test]

Copy link

github-actions bot commented Sep 11, 2025

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - 3.12CentOS-Stream-10x86_64✅ passed12.09.2025 09:50:4619min 22stest pipeline
CentOS Stream 9 - 3.9-minimalCentOS-Stream-9x86_64✅ passed12.09.2025 09:55:0218min 18stest pipeline
Fedora - 3.13Fedora-latestx86_64✅ passed12.09.2025 09:59:1419min 28stest pipeline
Fedora - 3.12-minimalFedora-latestx86_64✅ passed12.09.2025 10:23:2017min 24stest pipeline
RHEL8 - 3.9RHEL-8.10.0-Nightlyx86_64✅ passed12.09.2025 10:33:2230min 52stest pipeline
CentOS Stream 10 - 3.12-minimalCentOS-Stream-10x86_64✅ passed12.09.2025 10:15:2418min 13stest pipeline
CentOS Stream 9 - 3.12CentOS-Stream-9x86_64✅ passed12.09.2025 10:35:5122min 8stest pipeline
RHEL9 - 3.9RHEL-9.6.0-Nightlyx86_64✅ passed12.09.2025 10:38:1631min 11stest pipeline
CentOS Stream 9 - 3.9CentOS-Stream-9x86_64✅ passed12.09.2025 09:56:5920min 4stest pipeline
CentOS Stream 9 - 3.11-minimalCentOS-Stream-9x86_64✅ passed12.09.2025 09:59:4218min 27stest pipeline
RHEL9 - 3.12-minimalRHEL-9.6.0-Nightlyx86_64✅ passed12.09.2025 10:32:5929min 22stest pipeline
Fedora - 3.12Fedora-latestx86_64✅ passed12.09.2025 09:58:3020min 26stest pipeline
RHEL8 - 3.12RHEL-8.10.0-Nightlyx86_64✅ passed12.09.2025 10:23:2228min 14stest pipeline
CentOS Stream 9 - 3.12-minimalCentOS-Stream-9x86_64✅ passed12.09.2025 10:23:2319min 38stest pipeline
CentOS Stream 9 - 3.11CentOS-Stream-9x86_64✅ passed12.09.2025 10:23:0521min 43stest pipeline
RHEL10 - 3.12-minimalRHEL-10-Nightlyx86_64✅ passed12.09.2025 09:52:4821min 29stest pipeline
RHEL8 - 3.11-minimalRHEL-8.10.0-Nightlyx86_64✅ passed12.09.2025 10:22:3324min 21stest pipeline
RHEL8 - 3.9-minimalRHEL-8.10.0-Nightlyx86_64✅ passed12.09.2025 09:53:5324min 54stest pipeline
RHEL8 - 3.11RHEL-8.10.0-Nightlyx86_64✅ passed12.09.2025 10:27:4829min 14stest pipeline
RHEL9 - 3.12RHEL-9.6.0-Nightlyx86_64✅ passed12.09.2025 10:32:3232min 51stest pipeline
RHEL9 - 3.11RHEL-9.6.0-Nightlyx86_64✅ passed12.09.2025 09:50:3932min 4stest pipeline

Copy link
Member

@ljavorsk ljavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found one possible improvement in the template logic.

But let me open a broader discussion: What do we need the version label and version ENV variable for? I look at the history, and these versions are the same for many years now without any single change and they are just copy-pasted over and over.

@pkubatrh I saw your comment that we should keep the ENV version so you might know why we need it.

@pkubatrh
Copy link
Member

pkubatrh commented Sep 12, 2025

Version label - used to version the image. Historically required by the build system and used as part of the builds NVR. Usually set to 1 in case we ever need to break image compatibility we could increment this version and not break existing deployments. However this was never used (to my knowledge) and current build system ignores it, which is why we can remove it in RHEL10.
VERSION environment variable - Can be used in a variety ways (since it is accessible inside the image). Required for Fedora images so it might accidentally spill into other images as well due to copy-paste errors. Why keep it? Depends on the image really. It might be used inside the image, it might be used by its users in some way, or it might not be used at all.
But since these PRs are only about removing the label, we should focus on that.

@frenzymadness
Copy link
Member

Thanks for the context @pkubatrh ! Let's finish this PR, and I'll open a new one where I try to remove them both together with the associated logic, and we'll see what happens.

Konflux build pipeline needs it.
See https://issues.redhat.com/browse/RHELMISC-17288

Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek phracek force-pushed the remove_version_from_dockerfile_rhel10 branch from 130805c to 8224cf6 Compare September 12, 2025 09:47
@phracek
Copy link
Member Author

phracek commented Sep 12, 2025

[test]

@phracek phracek merged commit a7a6d2d into master Sep 12, 2025
22 checks passed
@phracek phracek deleted the remove_version_from_dockerfile_rhel10 branch September 12, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants