Add RHEL10 imagestreams #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing Farm results
|
phracek
force-pushed
the
add_rhel10_imagestreams
branch
from
579b8a6 to
4d755e5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
let's test it again as PR #743 was merged |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
phracek
force-pushed
the
add_rhel10_imagestreams
branch
from
4f1f147 to
48e6307
Compare
|
The latest commit 4f1f147 fixes proper detection json file. [test-all] |
befeleme
reviewed
Jun 11, 2025
| @@ -62,7 +62,7 @@ function test_python_imagestream() { | |||
| django-postgresql.json \ | |||
| django-postgresql-persistent.json" | |||
| for template in $TEMPLATES; do | |||
| ct_os_test_image_stream_quickstart "${THISDIR}/imagestreams/python-${OS%[0-9]*}.json" \ | |||
| ct_os_test_image_stream_quickstart "${THISDIR}/imagestreams/python-${OS//[0-9]/}.json" \ | |||
There was a problem hiding this comment.
I don't understand this change, could you please explain?
There was a problem hiding this comment.
Yeah, in case OS=rhel8 or rhel9, then the expression ${OS%[0-9]*} converts to rhel and result file is python-rhel.json, that exists.
But in case OS=rhel10 then the origin expression convers to rhel1 and the file python-rhel1.json does not exist.
There was a problem hiding this comment.
Aach, I see. // replaces all matches of digits with nothing (after /). % removes the suffix from the end. The same effect would have an expression ${OS%%[0-9]*} with double % sign to indicate the removal of the longest match from the end of the string. I have no opinion on what's better, but I learned something new today :)
UBI10 Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Fix regular expression for geting 'rhel' name from OS variable Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
add_rhel10_imagestreams
branch
from
e439b45 to
4f3123a
Compare
|
Rebased commits so they are easy to review. [test-all] |
befeleme
reviewed
Jun 11, 2025
|
CentOS Stream 9 with 3.9 and 3.11 fails but I have no idea why - couldn't find anything relevant in the logs. Do you know why it's failing? The commits themselves look good to me. |
Do not update in function ct_pull_or_import_postgresql Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
add_rhel10_imagestreams
branch
from
173b964 to
edef67d
Compare
|
Do not use CentOS 7 image for Postgresql that is a bit old. And let's use CentOS Stream 8 image that is a bit fresh. [test-all] |
|
Thank you @befeleme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds testing RHEL10 imagestreams in python container.
This pull request is blocked by #743