fix(tests): 1-120_validate_running_must_gather.go: Do not read file to memory + please gosec

Signed-off-by: Oliver Gondža <[email protected]>

Author: olivergondza

go.mod

@@ -18,6 +18,7 @@ require (
 	github.com/stretchr/testify v1.10.0
 	go.uber.org/zap v1.27.0
 	golang.org/x/mod v0.25.0
+	gopkg.in/yaml.v3 v3.0.1
 	gotest.tools v2.2.0+incompatible
 	k8s.io/api v0.33.2
 	k8s.io/apiextensions-apiserver v0.33.1
@@ -156,7 +157,6 @@ require (
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/warnings.v0 v0.1.2 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
 	k8s.io/apiserver v0.33.2 // indirect
 	k8s.io/cli-runtime v0.33.2 // indirect
 	k8s.io/component-base v0.33.2 // indirect

test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go

@@ -19,11 +19,14 @@ package parallel
 import (
 	"context"
 	"fmt"
-	osFixture "github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/os"
 	"os"
 	"path"
+	"path/filepath"
 	"strings"
 
+	osFixture "github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/os"
+	"gopkg.in/yaml.v3"
+
 	argov1beta1api "github.com/argoproj-labs/argocd-operator/api/v1beta1"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
@@ -32,7 +35,6 @@ import (
 	argocdFixture "github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/argocd"
 	fixtureUtils "github.com/redhat-developer/gitops-operator/test/openshift/e2e/ginkgo/fixture/utils"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"sigs.k8s.io/yaml"
 
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
@@ -165,14 +167,16 @@ func (matcher *validResourceFile) Match(actual any) (success bool, err error) {
 		return false, fmt.Errorf("BeValidResourceFile matcher expects a string (file path)")
 	}
 
-	content, err := os.ReadFile(filePath)
+	filePath = filepath.Clean(filePath)
+	f, err := os.Open(filePath)
 	if err != nil {
 		return false, fmt.Errorf("failed to read file: %v", err)
 	}
-	println(string(content))
+	defer f.Close()
 
+	decoder := yaml.NewDecoder(f)
 	var data map[string]any
-	if err := yaml.Unmarshal(content, &data); err != nil {
+	if err := decoder.Decode(&data); err != nil {
 		return false, fmt.Errorf("failed parsing supposed YAML file: %v", err)
 	}