Merge pull request #218 from Throne3d/fix/warn-on-no-names

Warn if a part/quit is received and no channelUsers is set

Author: ekmartin

lib/bot.js

@@ -146,7 +146,11 @@ class Bot {
         delete this.channelUsers[channel];
         return;
       }
-      this.channelUsers[channel].delete(nick);
+      if (this.channelUsers[channel]) {
+        this.channelUsers[channel].delete(nick);
+      } else {
+        logger.warn(`No channelUsers found for ${channel} when ${nick} parted.`);
+      }
       this.sendExactToDiscord(channel, `*${nick}* has left the channel (${reason})`);
     });
 
@@ -155,6 +159,10 @@ class Bot {
       if (!this.ircStatusNotices || nick === this.nickname) return;
       channels.forEach((channelName) => {
         const channel = channelName.toLowerCase();
+        if (!this.channelUsers[channel]) {
+          logger.warn(`No channelUsers found for ${channel} when ${nick} quit, ignoring.`);
+          return;
+        }
         if (!this.channelUsers[channel].delete(nick)) return;
         this.sendExactToDiscord(channel, `*${nick}* has quit (${reason})`);
       });

test/bot-events.test.js

@@ -263,6 +263,19 @@ describe('Bot Events', function () {
     bot.sendExactToDiscord.should.not.have.been.called;
   });
 
+  it('should warn if it receives a part/quit before a names event', function () {
+    const bot = createBot({ ...config, ircStatusNotices: true });
+    bot.connect();
+    const channel = '#channel';
+    const reason = 'Leaving';
+
+    bot.ircClient.emit('part', channel, 'user1', reason);
+    bot.ircClient.emit('quit', 'user2', reason, [channel]);
+    this.warnSpy.should.have.been.calledTwice;
+    this.warnSpy.getCall(0).args.should.deep.equal([`No channelUsers found for ${channel} when user1 parted.`]);
+    this.warnSpy.getCall(1).args.should.deep.equal([`No channelUsers found for ${channel} when user2 quit, ignoring.`]);
+  });
+
   it('should not listen to discord debug messages in production', function () {
     logger.level = 'info';
     const bot = createBot();