Skip to content

Commit 5f77da3

Browse files
committed
Report "virtual base at offset 0" but don't skip test.
1 parent 262a609 commit 5f77da3

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

tests/test_class_sh_mi_thunks.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,12 @@ def test_get_shared_vec_size_unique():
5353
)
5454

5555

56-
def _delta_nonzero():
57-
a = m.diamond_addrs()
58-
return (a.as_vbase - a.as_self) != 0
56+
def test_virtual_base_at_offset_0():
57+
addrs = m.diamond_addrs()
58+
if addrs.as_vbase - addrs.as_self == 0:
59+
pytest.skip("virtual base at offset 0 on this compiler/layout")
5960

6061

61-
@pytest.mark.skipif(
62-
not _delta_nonzero(), reason="virtual base at offset 0 on this compiler/layout"
63-
)
6462
def test_shared_ptr_return_to_virtual_base_triggers_vi_path():
6563
# This exercised the broken seam pre-fix.
6664
vb = m.make_diamond_as_vbase()

0 commit comments

Comments
 (0)