Skip to content

Field containerLogs in docker:index/container:Container is incorrectly set as required #1052

@andrzejressel

Description

@andrzejressel

What happened?

containerLogs is set as required in schema

"required": [
"bridge",
"command",
"containerLogs",
while the description is "The logs of the container if its execution is done (attach must be disabled)." - and it indeed is not returned in persistent containers:

https://github.com/kreuzwerker/terraform-provider-docker/blob/54685a5fb9b375961620d2c555c7f3925327112c/internal/provider/resource_docker_container_funcs.go#L535-L581

This field is not required in original provider: https://github.com/kreuzwerker/terraform-provider-docker/blob/54685a5fb9b375961620d2c555c7f3925327112c/internal/provider/resource_docker_container.go#L123-L127

Example

N/A

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Metadata

Metadata

Assignees

No one assigned

    Labels

    awaiting-feedbackBlocked on input from the authorcustomer/feedbackFeedback from customersimpact/breakingFixing this issue will require a breaking changekind/bugSome behavior is incorrect or out of spec

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions