fix(plugin): Use correct and slightly randomized remote image name

Author: tonyo

docker-pussh

@@ -321,17 +321,17 @@ if [ -n "$SSH_KEY" ] && [ ! -f "$SSH_KEY" ]; then
     error "SSH key file not found: $SSH_KEY"
 fi
 
-extract_image_name_and_tag() {
-  local regex="^(.*:.*?\/)?(.*\/)?(.*)$"
-  local image_name_tag
-
-  if [[ $IMAGE =~ $regex ]]
-  then
-    image_name_tag=${BASH_REMATCH[3]}
-    echo "$image_name_tag"
+get_temp_image_name() {
+  local image=$1
+  local regex="^(.*:.*?\/)?(.*\/)?(.+)$"
+  local repo_with_tag
+
+  if [[ $image =~ $regex ]]; then
+    repo_with_tag=${BASH_REMATCH[3]}
+    echo "${RANDOM}-${repo_with_tag}"
     return 0
   else
-    error "Error parsing reference $IMAGE is not a valid  repository/tag: invalid reference format"
+    error "Error parsing reference: ${image} is not a valid image reference."
   fi
 }
 
@@ -388,7 +388,7 @@ if is_additional_tunneling_needed; then
     success "Additional tunnel created: localhost:$PUSH_PORT → localhost:$LOCAL_PORT"
 fi
 
-IMAGE_NAME_TAG=$(extract_image_name_and_tag)
+IMAGE_NAME_TAG=$(get_temp_image_name "${IMAGE}")
 # Tag and push the image to unregistry through the forwarded port.
 REGISTRY_IMAGE="localhost:$PUSH_PORT/$IMAGE_NAME_TAG"
 docker tag "$IMAGE" "$REGISTRY_IMAGE"
@@ -407,20 +407,22 @@ fi
 REMOTE_REGISTRY_IMAGE=""
 # Pull image from unregistry if remote Docker doesn't uses containerd image store.
 # shellcheck disable=SC2029
-if ! ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker info -f '{{ .DriverStatus }}' | grep -q 'containerd.snapshotter'"; then
+if ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker info -f '{{ .DriverStatus }}' | grep -q 'containerd.snapshotter'"; then
+    # Remote image store uses containerd, so we can use the image directly.
+    REMOTE_REGISTRY_IMAGE="$IMAGE_NAME_TAG"
+else
     info "Remote Docker doesn't use containerd image store. Pulling image from unregistry..."
-
     REMOTE_REGISTRY_IMAGE="localhost:$UNREGISTRY_PORT/$IMAGE_NAME_TAG"
     if ! ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker pull $REMOTE_REGISTRY_IMAGE"; then
         error "Failed to pull image from unregistry on remote host."
     fi
-else
-    REMOTE_REGISTRY_IMAGE="$REGISTRY_IMAGE"
 fi
 
+# shellcheck disable=SC2029
 if ! ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker tag $REMOTE_REGISTRY_IMAGE $IMAGE"; then
     error "Failed to retag image on remote host $REMOTE_REGISTRY_IMAGE → $IMAGE"
 fi
+# shellcheck disable=SC2029
 ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker rmi $REMOTE_REGISTRY_IMAGE" >/dev/null || true
 
 info "Removing unregistry container on remote host..."