fixes from review

Author: Jonathan Mabit

docker-pussh

@@ -321,11 +321,15 @@ if [ -n "$SSH_KEY" ] && [ ! -f "$SSH_KEY" ]; then
     error "SSH key file not found: $SSH_KEY"
 fi
 
-parse_image() {
-  regex="^(.*:.*?\/)?(.*\/)?(.*)$"
+extract_image_name_and_tag() {
+  local regex="^(.*:.*?\/)?(.*\/)?(.*)$"
+  local image_name_tag
+
   if [[ $IMAGE =~ $regex ]]
   then
-    IMAGE_NAME_TAG=${BASH_REMATCH[3]}
+    image_name_tag=${BASH_REMATCH[3]}
+    echo "$image_name_tag"
+    return 0
   else
     error "Error parsing reference $IMAGE is not a valid  repository/tag: invalid reference format"
   fi
@@ -384,7 +388,7 @@ if is_additional_tunneling_needed; then
     success "Additional tunnel created: localhost:$PUSH_PORT → localhost:$LOCAL_PORT"
 fi
 
-parse_image
+IMAGE_NAME_TAG=$(extract_image_name_and_tag)
 # Tag and push the image to unregistry through the forwarded port.
 REGISTRY_IMAGE="localhost:$PUSH_PORT/$IMAGE_NAME_TAG"
 docker tag "$IMAGE" "$REGISTRY_IMAGE"
@@ -407,11 +411,11 @@ if ! ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker info -f '{{ .DriverStatus }}' | g
     info "Remote Docker doesn't use containerd image store. Pulling image from unregistry..."
 
     REMOTE_REGISTRY_IMAGE="localhost:$UNREGISTRY_PORT/$IMAGE_NAME_TAG"
-    if ! ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker pull $remote_registry_image"; then
+    if ! ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker pull $REMOTE_REGISTRY_IMAGE"; then
         error "Failed to pull image from unregistry on remote host."
     fi
 else
-    REMOTE_REGISTRY_IMAGE="$IMAGE_NAME_TAG"
+    REMOTE_REGISTRY_IMAGE="$REGISTRY_IMAGE"
 fi
 
 if ! ssh "${SSH_ARGS[@]}" "$REMOTE_SUDO docker tag $REMOTE_REGISTRY_IMAGE $IMAGE"; then