Skip to content

Add official GitHub star count button above the fold #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add official GitHub star count button above the fold #197

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5cd5095
fix #4280 add official GitHub star count button
germainelee Apr 11, 2025
ef93524
small spacing fix
germainelee Apr 11, 2025
5da7fbe
revise aria label and button label
germainelee Apr 24, 2025
adb4ff7
Merge branch 'owncast:master' into master
germainelee May 5, 2025
f44c663
Merge branch 'owncast:master' into master
germainelee May 12, 2025
e1eb04a
Merge branch 'owncast:master' into master
germainelee May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions layouts/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
</figure>

<div class="intro col-lg-7 col-md-16">
<a class="github-button" href="https://github.com/owncast/owncast" data-color-scheme="no-preference: dark; light: dark; dark: dark;" data-size="large" data-show-count="true" aria-label="Star owncast/owncast on GitHub">Star</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label says "star owncast on github" but pressing this button will not star Owncast on github.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is designed to work like that only because of security issues- buttons/github-buttons#10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know why, but I'm just saying it's not accurate. It's not possible to star a repository this way, so we shouldn't say that the button does so.

Copy link
Contributor Author

@germainelee germainelee Apr 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to write "View owncast/owncast on Github" as the aria label and "Github" as button label?

<p class="lead">Owncast is a free and open source live video and web chat server for use with existing popular broadcasting software.</p>
<a class="btn btn-primary btn-lg px-4 mb-2" href="{{ "quickstart/" | absURL }}" role="button">Get started</a>
</div>
Expand All @@ -30,6 +31,8 @@
}
}
</script>
<!-- GitHub Star Button -->
<script async defer src="https://buttons.github.io/buttons.js"></script>
</section>

<!-- 4 key points section -->
Expand Down