Skip to content

Commit 91f89e4

Browse files
committed
updates
1 parent 3b196ce commit 91f89e4

File tree

2 files changed

+24
-16
lines changed

2 files changed

+24
-16
lines changed

engine/plugins/api/gleif/types.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ type leiRecord struct {
6868
LEI string `json:"lei"`
6969
Entity struct {
7070
LegalName struct {
71-
Name string `json:"name"`
72-
Lang string `json:"language"`
71+
Name string `json:"name"`
72+
Language string `json:"language"`
7373
} `json:"legalName"`
7474
OtherNames []string `json:"otherNames"`
7575
TransliteratedOtherNames []string `json:"transliteratedOtherNames"`
@@ -168,7 +168,7 @@ type leiEntity struct {
168168
}
169169

170170
type leiAddress struct {
171-
Lang string `json:"language"`
171+
Language string `json:"language"`
172172
AddressLines []string `json:"addressLines"`
173173
AddressNumber string `json:"addressNumber"`
174174
AddressNumberWithinBuilding string `json:"addressNumberWithinBuilding"`

engine/plugins/support/database.go

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,10 @@ func CreateOrgAsset(session et.Session, obj *dbt.Entity, rel oam.Relation, o *or
241241
if o == nil || o.Name == "" {
242242
return nil, errors.New("missing the organization name")
243243
}
244-
if obj != nil && rel != nil && src != nil {
244+
if src == nil {
245+
return nil, errors.New("missing the source")
246+
}
247+
if obj != nil && rel != nil {
245248
if orgent := orgDedupChecks(session, obj, o); orgent != nil {
246249
if err := createRelation(session, obj, rel, orgent, src); err != nil {
247250
return nil, err
@@ -283,32 +286,37 @@ func CreateOrgAsset(session et.Session, obj *dbt.Entity, rel oam.Relation, o *or
283286
}
284287

285288
func orgDedupChecks(session et.Session, obj *dbt.Entity, o *org.Organization) *dbt.Entity {
286-
var result *dbt.Entity
287-
288289
switch obj.Asset.(type) {
289290
case *contact.ContactRecord:
290-
if org, found := orgNameExistsInContactRecord(session, obj, o.Name); found {
291-
result = org
291+
for _, name := range []string{o.Name, o.LegalName} {
292+
if name != "" {
293+
if org, found := orgNameExistsInContactRecord(session, obj, name); found {
294+
return org
295+
}
296+
}
292297
}
293298
if org, err := orgExistsAndSharesLocEntity(session, obj, o); err == nil {
294-
result = org
299+
return org
295300
}
296301
if org, err := orgExistsAndSharesAncestorEntity(session, obj, o); err == nil {
297-
result = org
302+
return org
298303
}
299304
case *org.Organization:
300-
if org, found := orgNameRelatedToOrganization(session, obj, o.Name); found {
301-
result = org
305+
for _, name := range []string{o.Name, o.LegalName} {
306+
if name != "" {
307+
if org, found := orgNameRelatedToOrganization(session, obj, name); found {
308+
return org
309+
}
310+
}
302311
}
303312
if org, err := orgExistsAndSharesLocEntity(session, obj, o); err == nil {
304-
result = org
313+
return org
305314
}
306315
if org, err := orgExistsAndSharesAncestorEntity(session, obj, o); err == nil {
307-
result = org
316+
return org
308317
}
309318
}
310-
311-
return result
319+
return nil
312320
}
313321

314322
func orgHasName(session et.Session, org *dbt.Entity, name string) bool {

0 commit comments

Comments
 (0)