fix(core): fix incorrect pagination params in iceberg fetch

ref: #PRDCOL-181

Signed-off-by: Atef ZAAFOURI <[email protected]>

Author: atefzed

packages/manager/core/api/src/iceberg.ts

@@ -2,7 +2,11 @@ import { AxiosResponse } from 'axios';
 
 import { apiClient } from './client.js';
 import { transformTagsFiltersToQuery } from './filters.js';
-import { Filter, FilterComparator, FilterTypeCategories } from './types/filters.type.js';
+import {
+  Filter,
+  FilterComparator,
+  FilterTypeCategories,
+} from './types/filters.type.js';
 import {
   IcebergFetchParamsV2,
   IcebergFetchParamsV6,
@@ -24,7 +28,10 @@ export const appendIamTags = (
   return params;
 };
 
-export function icebergFilter(comparator: FilterComparator, value: string | string[]) {
+export function icebergFilter(
+  comparator: FilterComparator,
+  value: string | string[],
+) {
   const v = encodeURIComponent(String(value || ''));
   switch (comparator) {
     case FilterComparator.Includes:
@@ -78,7 +85,7 @@ export const buildHeaders = () => {
       return builder;
     },
     setDisabledCache: (disableCache: boolean | undefined) => {
-      if (disableCache) headers['Pragma'] = 'no-cache';
+      if (disableCache) headers.Pragma = 'no-cache';
       return builder;
     },
     setPaginationSort: (sortBy: string | undefined, sortOrder = 'ASC') => {
@@ -94,7 +101,10 @@ export const buildHeaders = () => {
           .filter(({ type }) => type !== FilterTypeCategories.Tags)
           .map(
             ({ comparator, key, value }) =>
-              `${encodeURIComponent(key)}:${icebergFilter(comparator, String(value || ''))}`,
+              `${encodeURIComponent(key)}:${icebergFilter(
+                comparator,
+                String(value || ''),
+              )}`,
           )
           .join('&');
         if (filtersJoin) {
@@ -107,7 +117,11 @@ export const buildHeaders = () => {
       headers[key] = value;
       return builder;
     },
-    setIamTags: (params: URLSearchParams, filters: Filter[] | undefined, paramName = 'iamTags') => {
+    setIamTags: (
+      params: URLSearchParams,
+      filters: Filter[] | undefined,
+      paramName = 'iamTags',
+    ) => {
       appendIamTags(params, filters, paramName);
       return builder;
     },
@@ -141,7 +155,11 @@ export async function fetchIcebergV2<T>({
     .setDisabledCache(disableCache)
     .setPaginationSort(sortBy, sortOrder)
     .setPaginationFilter(filters)
-    .setIamTags(params, filters, route.includes('/iam/resource') ? 'tags' : 'iamTags')
+    .setIamTags(
+      params,
+      filters,
+      route.includes('/iam/resource') ? 'tags' : 'iamTags',
+    )
     .build();
 
   const response: AxiosResponse<T[]> = await apiClient.v2.get<T[]>(
@@ -153,7 +171,7 @@ export async function fetchIcebergV2<T>({
 
   return {
     data: response.data,
-    cursorNext: headers['x-pagination-cursor-next'] ?? '',
+    cursorNext: headers['x-pagination-cursor-next'],
     status: response.status,
   };
 }

packages/manager/core/api/src/types/iceberg.type.ts

@@ -32,6 +32,6 @@ export type IcebergFetchResultV6<T> = {
 
 export type IcebergFetchResultV2<T> = {
   data: T[];
-  cursorNext: string;
+  cursorNext?: string;
   status: number;
 };