feat(okms): add CAS parameter support for creating secret versions

ref: #MANAGER-19608

Signed-off-by: Mathieu Mousnier <[email protected]>

Author: mathieumousnier

packages/manager/apps/key-management-service/src/modules/secret-manager/data/api/secretVersions.ts

@@ -38,16 +38,27 @@ export type CreateSecretVersionParams = {
   okmsId: string;
   path: string;
   data: CreateSecretVersionBody;
+  cas?: number;
 };
 
 export const createSecretVersion = async ({
   okmsId,
   path,
   data,
+  cas,
 }: CreateSecretVersionParams) => {
+  const queryParams = new URLSearchParams();
+  if (cas) {
+    queryParams.set('cas', cas.toString());
+  }
+  const queryString = queryParams.toString();
+  const url = `okms/resource/${okmsId}/secret/${encodeURIComponent(
+    path,
+  )}/version${queryString ? `?${queryString}` : ''}`;
+
   const { data: response } = await apiClient.v2.post<
     CreateSecretVersionResponse
-  >(`okms/resource/${okmsId}/secret/${encodeURIComponent(path)}/version`, {
+  >(url, {
     data,
   });
   return response;

packages/manager/apps/key-management-service/src/modules/secret-manager/pages/drawers/createVersionDrawer/CreateVersionDrawer.page.spec.tsx

@@ -1,7 +1,7 @@
 import React from 'react';
 import { vi } from 'vitest';
 import { SECRET_MANAGER_ROUTES_URLS } from '@secret-manager/routes/routes.constants';
-import { mockSecret1WithData } from '@secret-manager/mocks/secrets/secrets.mock';
+import { mockSecret2WithData } from '@secret-manager/mocks/secrets/secrets.mock';
 import { screen, act, fireEvent, waitFor } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import {
@@ -13,11 +13,12 @@ import {
   getOdsButtonByLabel,
   WAIT_FOR_DEFAULT_OPTIONS,
 } from '@ovh-ux/manager-core-test-utils';
+import * as secretVersionsApi from '@secret-manager/data/api/secretVersions';
 import { renderTestApp } from '@/utils/tests/renderTestApp';
 import { labels } from '@/utils/tests/init.i18n';
 
 const mockDomainId = '123123';
-const mockSecretPath = mockSecret1WithData.path;
+const mockSecretPath = mockSecret2WithData.path;
 const mockPageUrl = SECRET_MANAGER_ROUTES_URLS.secretVersionsDrawerCreateVersion(
   mockDomainId,
   mockSecretPath,
@@ -83,12 +84,15 @@ describe('Secret create version drawer page test suite', () => {
     // Check if the data input contains the secret value
     expect(dataInput).toBeInTheDocument();
     expect(dataInput).toHaveValue(
-      JSON.stringify(mockSecret1WithData.version.data),
+      JSON.stringify(mockSecret2WithData.version.data),
     );
   });
 
-  it('should close the drawer after submission', async () => {
+  it('should add cas to the createSecretVersion request and close the drawer after submission', async () => {
     const { container, user } = await renderPage();
+    vi.spyOn(secretVersionsApi, 'createSecretVersion').mockResolvedValue(
+      mockSecret2WithData.version,
+    );
 
     // Get the data input
     const dataInput = await screen.findByTestId(DATA_INPUT_TEST_ID);
@@ -115,6 +119,16 @@ describe('Secret create version drawer page test suite', () => {
 
     await act(() => user.click(submitButton));
 
+    // Wait for the createSecretVersion to be called
+    await waitFor(() => {
+      expect(secretVersionsApi.createSecretVersion).toHaveBeenCalledWith({
+        okmsId: mockDomainId,
+        path: mockSecret2WithData.path,
+        data: JSON.parse(MOCK_DATA_VALID_JSON),
+        cas: mockSecret2WithData.metadata.currentVersion,
+      });
+    });
+
     // Wait for the drawer to close
     await waitFor(() => {
       expect(

packages/manager/apps/key-management-service/src/modules/secret-manager/pages/drawers/createVersionDrawer/CreateVersionDrawer.page.tsx

@@ -63,6 +63,10 @@ const CreateVersionDrawerForm = ({
       okmsId: domainId,
       path: decodeSecretPath(secretPath),
       data: JSON.parse(data.data),
+      // Add current version to cas parameter if cas is required
+      cas: secret?.metadata?.casRequired
+        ? secret?.metadata?.currentVersion
+        : undefined,
     });
     onDismiss();
   };