fix(kmip): fix CryptographicAlgorithm xml names (#40)

BREAKING CHANGE: rename CryptographicAlgorithm TDES to 3DES

Signed-off-by: Pierre-Henri Symoneaux <[email protected]>

Author: phsym

enums.go

@@ -90,17 +90,17 @@ func init() {
 	})
 	ttlv.RegisterEnum(TagCryptographicAlgorithm, map[CryptographicAlgorithm]string{
 		CryptographicAlgorithmDES:        "DES",
-		CryptographicAlgorithmTDES:       "TDES",
+		CryptographicAlgorithm3DES:       "DES3",
 		CryptographicAlgorithmAES:        "AES",
 		CryptographicAlgorithmRSA:        "RSA",
 		CryptographicAlgorithmDSA:        "DSA",
 		CryptographicAlgorithmECDSA:      "ECDSA",
-		CryptographicAlgorithmHMACSHA1:   "HMACSHA1",
-		CryptographicAlgorithmHMACSHA224: "HMACSHA224",
-		CryptographicAlgorithmHMACSHA256: "HMACSHA256",
-		CryptographicAlgorithmHMACSHA384: "HMACSHA384",
-		CryptographicAlgorithmHMACSHA512: "HMACSHA512",
-		CryptographicAlgorithmHMACMD5:    "HMACMD5",
+		CryptographicAlgorithmHMACSHA1:   "HMAC_SHA1",
+		CryptographicAlgorithmHMACSHA224: "HMAC_SHA224",
+		CryptographicAlgorithmHMACSHA256: "HMAC_SHA256",
+		CryptographicAlgorithmHMACSHA384: "HMAC_SHA384",
+		CryptographicAlgorithmHMACSHA512: "HMAC_SHA512",
+		CryptographicAlgorithmHMACMD5:    "HMAC_MD5",
 		CryptographicAlgorithmDH:         "DH",
 		CryptographicAlgorithmECDH:       "ECDH",
 		CryptographicAlgorithmECMQV:      "ECMQV",
@@ -816,7 +816,7 @@ type CryptographicAlgorithm uint32
 
 const (
 	CryptographicAlgorithmDES        CryptographicAlgorithm = 0x00000001
-	CryptographicAlgorithmTDES       CryptographicAlgorithm = 0x00000002
+	CryptographicAlgorithm3DES       CryptographicAlgorithm = 0x00000002
 	CryptographicAlgorithmAES        CryptographicAlgorithm = 0x00000003
 	CryptographicAlgorithmRSA        CryptographicAlgorithm = 0x00000004
 	CryptographicAlgorithmDSA        CryptographicAlgorithm = 0x00000005

kmipclient/create.go

@@ -57,7 +57,7 @@ func (ex ExecCreateWantType) Object(objectType kmip.ObjectType, attrs ...kmip.At
 // the object type to SymmetricKey and attaches the relevant cryptographic attributes.
 //
 // Parameters:
-//   - alg: The cryptographic algorithm to use for the symmetric key (e.g., AES, TDES).
+//   - alg: The cryptographic algorithm to use for the symmetric key (e.g., AES, 3DES).
 //   - length: The length of the key in bits. Must be between 0 and math.MaxInt32.
 //   - usage: The intended usage mask for the key (bitmask of allowed operations).
 //
@@ -95,23 +95,23 @@ func (ex ExecCreateWantType) AES(length int, usage kmip.CryptographicUsageMask)
 	return ex.SymmetricKey(kmip.CryptographicAlgorithmAES, length, usage)
 }
 
-// TDES creates a symmetric key using the Triple DES (TDES) cryptographic algorithm with the specified key length and usage mask.
-// It returns an ExecCreate configured for TDES key creation.
+// TDES creates a symmetric key using the 3DES cryptographic algorithm with the specified key length and usage mask.
+// It returns an ExecCreate configured for 3DES key creation.
 //
 // Parameters:
-//   - length: The length of the TDES key in bits.
+//   - length: The length of the 3DES key in bits.
 //   - usage: The intended cryptographic usage mask for the key.
 //
 // Returns:
-//   - ExecCreate: An instance configured for TDES key creation.
+//   - ExecCreate: An instance configured for 3DES key creation.
 //
-// Deprecated: TDES is considered insecure and shouldn't be used.
+// Deprecated: 3DES is considered insecure and shouldn't be used.
 //
 // Errors:
 //   - Panics if length is negative or exceeds math.MaxInt32.
 //   - Errors may be returned when executing the operation if the server does not support the requested key length.
 func (ex ExecCreateWantType) TDES(length int, usage kmip.CryptographicUsageMask) ExecCreate {
-	return ex.SymmetricKey(kmip.CryptographicAlgorithmTDES, length, usage)
+	return ex.SymmetricKey(kmip.CryptographicAlgorithm3DES, length, usage)
 }
 
 // Skipjack creates a symmetric key with the SKIPJACK cryptographic algorithm and a key length of 80 bits.