Skip to content

Commit f8d0494

Browse files
Always enable kube-proxy and dns metrics
This was a regression from 3.9
1 parent e365fbc commit f8d0494

File tree

1 file changed

+4
-3
lines changed
  • pkg/cmd/server/kubernetes/network/options

1 file changed

+4
-3
lines changed

pkg/cmd/server/kubernetes/network/options/options.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,10 @@ func Build(options configapi.NodeConfig) (*kubeproxyconfig.KubeProxyConfiguratio
3939
return nil, fmt.Errorf("The provided value to bind to must be an ip:port: %q", addr)
4040
}
4141
proxyconfig.BindAddress = ip.String()
42-
// MetricsBindAddress - disable by default but allow enablement until we switch to
43-
// reading proxy config directly
44-
proxyconfig.MetricsBindAddress = ""
42+
// MetricsBindAddress - enable as a separate port in the 11xxx range for now, but only
43+
// on localhost. Metrics contains no tenant information.
44+
// TODO: move this to a secured port that we can query from prometheus.
45+
proxyconfig.MetricsBindAddress = "localhost:11256"
4546
if arg := options.ProxyArguments["metrics-bind-address"]; len(arg) > 0 {
4647
proxyconfig.MetricsBindAddress = arg[0]
4748
}

0 commit comments

Comments
 (0)